| commit | 8d6ba49563600d8e65c7f56fb0f29e23a571a75f | |
| author | Matthew DeVore <matvore@google.com> | |
| Fri, 5 Oct 2018 21:54:07 +0000 (5 14:54 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sat, 6 Oct 2018 23:51:18 +0000 (7 08:51 +0900) | ||
| tree | 16c19d5d3fc8c85a1c136ae2b10249ccd4cbe372 | treesnapshot (tar.gz zip) |
| parent | b00b6ace5c92ef4c2893f7b7cc597a0297812a52 | commitdiff |
tests: order arguments to git-rev-list properly
It is a common mistake to put positional arguments before flags when
invoking git-rev-list. Order the positional arguments last.
This patch skips git-rev-list invocations which include the --not flag,
since the ordering of flags and positional arguments affects the
behavior. This patch also skips invocations of git-rev-list that occur
in command substitution in which the exit code is discarded, since
fixing those properly will require a more involved cleanup.
Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
It is a common mistake to put positional arguments before flags when
invoking git-rev-list. Order the positional arguments last.
This patch skips git-rev-list invocations which include the --not flag,
since the ordering of flags and positional arguments affects the
behavior. This patch also skips invocations of git-rev-list that occur
in command substitution in which the exit code is discarded, since
fixing those properly will require a more involved cleanup.
Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t5616-partial-clone.sh | diffblobblamehistory | |
| t/t5702-protocol-v2.sh | diffblobblamehistory | |
| t/t6112-rev-list-filters-objects.sh | diffblobblamehistory |