| commit | 8cdef01c4282e6006b785a0222589ccd2b65a187 | |
| author | SZEDER Gábor <szeder.dev@gmail.com> | |
| Thu, 8 Feb 2018 15:56:48 +0000 (8 16:56 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 8 Feb 2018 18:54:27 +0000 (8 10:54 -0800) | ||
| tree | ad20e4d48303b1148ece68c6aaf1121bfb4631cb | treesnapshot (tar.gz zip) |
| parent | 8279ed033f703d4115bee620dccd32a9ec94d9aa | commitdiff |
t5541: add 'test_i18ngrep's missing filename parameter
The test 'push --no-progress silences progress but not status' runs
'test_i18ngrep' without specifying a filename parameter. This has
remained unnoticed since its introduction in e304aeba2 (t5541: test
more combinations of --progress, 2012-05-01), because that
'test_i18ngrep' is supposed to check that the given pattern is not
present in its input, and of course it won't find that pattern if its
input is empty (as it comes from /dev/null). This also means that
this test could miss a potential breakage of 'git push --no-progress'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The test 'push --no-progress silences progress but not status' runs
'test_i18ngrep' without specifying a filename parameter. This has
remained unnoticed since its introduction in e304aeba2 (t5541: test
more combinations of --progress, 2012-05-01), because that
'test_i18ngrep' is supposed to check that the given pattern is not
present in its input, and of course it won't find that pattern if its
input is empty (as it comes from /dev/null). This also means that
this test could miss a potential breakage of 'git push --no-progress'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t5541-http-push-smart.sh | diffblobblamehistory |