| commit | 88c6e9d31c695c4500376284a4c3b0e17b665781 | |
| author | Jeff King <peff@peff.net> | |
| Tue, 5 Sep 2017 13:03:54 +0000 (5 09:03 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 6 Sep 2017 09:06:26 +0000 (6 18:06 +0900) | ||
| tree | 2e396224e325fa02275832f56e97e895691ded50 | treesnapshot (tar.gz zip) |
| parent | 3ec7d702a89c647ddf42a59bc3539361367de9d5 | commitdiff |
test-lib: --valgrind should not override --verbose-log
The --verbose test option cannot be used with test harnesses
like "prove". Instead, you must use --verbose-log.
Since the --valgrind option implies --verbose, that means
that it cannot be used with prove. I.e., this does not work:
prove t0000-basic.sh :: --valgrind
You'd think it could be fixed by doing:
prove t0000-basic.sh :: --valgrind --verbose-log
but that doesn't work either, because the implied --verbose
takes precedence over --verbose-log. If the user has given
us a specific option, we should prefer that.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The --verbose test option cannot be used with test harnesses
like "prove". Instead, you must use --verbose-log.
Since the --valgrind option implies --verbose, that means
that it cannot be used with prove. I.e., this does not work:
prove t0000-basic.sh :: --valgrind
You'd think it could be fixed by doing:
prove t0000-basic.sh :: --valgrind --verbose-log
but that doesn't work either, because the implied --verbose
takes precedence over --verbose-log. If the user has given
us a specific option, we should prefer that.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/test-lib.sh | diffblobblamehistory |