advice: don't pointlessly suggest --convert-graft-file
commit8821e90a09a6b86b92213882f3b9945bc21b94d1
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 27 Nov 2018 20:12:55 +0000 (27 21:12 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 29 Nov 2018 06:15:17 +0000 (29 15:15 +0900)
tree7ad44326a26b847e48df28612615dc6a218efba5
parent98cdfbb84ad2ed6a2eb43dafa357a70a4b0a0fad
advice: don't pointlessly suggest --convert-graft-file

The advice to run 'git replace --convert-graft-file' added in
f9f99b3f7d ("Deprecate support for .git/info/grafts", 2018-04-29)
didn't add an exception for the 'git replace --convert-graft-file'
codepath itself.

As a result we'd suggest running --convert-graft-file while the user
was running --convert-graft-file, which makes no sense. Before:

    $ git replace --convert-graft-file
    hint: Support for <GIT_DIR>/info/grafts is deprecated
    hint: and will be removed in a future Git version.
    hint:
    hint: Please use "git replace --convert-graft-file"
    hint: to convert the grafts into replace refs.
    hint:
    hint: Turn this message off by running
    hint: "git config advice.graftFileDeprecated false"

Add a check for that case and skip printing the advice while the user
is busy following our advice.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/replace.c
t/t6050-replace.sh