revision: disallow reflog walking with revs->limited
commit82fd0f4a4b2c394ddba279eab7072fe87b750d2e
authorJeff King <peff@peff.net>
Fri, 7 Jul 2017 09:07:16 +0000 (7 05:07 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 7 Jul 2017 17:04:53 +0000 (7 10:04 -0700)
treedbbf242d07813060d816cc14a661b7bb1f50c075
parent7cf686b9a89d3cea269dfcced2d32dff56a5f01d
revision: disallow reflog walking with revs->limited

The reflog-walk code doesn't work with limit_list().  That
function traverses down the real history graph, not the fake
reflog history that get_revision() returns. So it's not
going to actually examine all of the commits we're going to
show, because we'd add them to the pending list only during
the actual traversal.

In practice this limitation doesn't really matter, because
the options that require list-limiting generally need
UNINTERESTING endpoints or symmetric ranges, which already
are forbidden for reflog walks. Still, there are likely some
corner cases that would behave oddly. We're better off to
warn the user that we can't fulfill their request than to
generate potentially wrong output.

This will also make it easier to refactor the reflog-walking
code, because it eliminates a whole area of corner cases
we'd have to consider (that already don't work anyway).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
revision.c