completion: expand "push --delete <remote> <ref>" for refs on that <remote>
commit723c1d526faaee6fac9b804f4b97b148f450eb5d
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sat, 22 Apr 2017 17:55:04 +0000 (22 17:55 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 24 Apr 2017 00:30:59 +0000 (23 17:30 -0700)
tree8fd7c3144536c510507246c5d8c119a5ba0631d4
parent584f8975d2d9530a34bd0b936ae774f82fe30fed
completion: expand "push --delete <remote> <ref>" for refs on that <remote>

Change the completion of "push --delete <remote> <ref>" to complete
refs on that <remote>, not all refs.

Before this cloning git.git and doing "git push --delete origin
p<TAB>" will complete nothing, since a fresh clone of git.git will
have no "pu" branch, whereas origin/p<TAB> will uselessly complete
origin/pu, but fully qualified references aren't accepted by
"--delete".

Now p<TAB> will complete as "pu". The completion of giving --delete
later, e.g. "git push origin --delete p<TAB>" remains unchanged, this
is a bug, but is a general existing limitation of the bash completion,
and not how git-push is documented, so I'm not fixing that case, but
adding a failing TODO test for it.

The testing code was supplied by SZEDER Gábor in
<20170421122832.24617-1-szeder.dev@gmail.com> with minor setup
modifications on my part.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: SZEDER Gábor <szeder.dev@gmail.com>
Test-code-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/completion/git-completion.bash
t/t9902-completion.sh