| commit | 70c7bd6dafc83eee7bf76d33d12027224d80f20d | |
| author | Jeff King <peff@peff.net> | |
| Sat, 26 Apr 2014 20:00:55 +0000 (26 22:00 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 29 Apr 2014 19:38:32 +0000 (29 12:38 -0700) | ||
| tree | 6ffbc266b38c277b3e0a5be9e10b8e1ee6251acf | treesnapshot (tar.gz zip) |
| parent | 3f495f67bc4ec744ac60f6e7bec0924022670998 | commitdiff |
replace: use OPT_CMDMODE to handle modes
By using OPT_CMDMODE, the mutual exclusion between modes is
taken care of for us. It also makes it easy for us to
maintain a single variable with the mode, which makes its
intent more clear. We can use a single switch() to make sure
we have covered all of the modes.
This ends up breaking even in code size, but the win will be
much bigger when we start adding more modes.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
By using OPT_CMDMODE, the mutual exclusion between modes is
taken care of for us. It also makes it easy for us to
maintain a single variable with the mode, which makes its
intent more clear. We can use a single switch() to make sure
we have covered all of the modes.
This ends up breaking even in code size, but the win will be
much bigger when we start adding more modes.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/replace.c | diffblobblamehistory |