| commit | 6aed56736b882f94c81293d1646d27d10241349c | |
| author | Jeff King <peff@peff.net> | |
| Thu, 7 Jan 2021 09:44:17 +0000 (7 04:44 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 7 Jan 2021 22:25:44 +0000 (7 14:25 -0800) | ||
| tree | 71e2194d1e94b8688f89d1b710dd6cf062b5f3a3 | treesnapshot (tar.gz zip) |
| parent | a02ea577174ab8ed18f847cf1693f213e0b9c473 | commitdiff |
fsck: reject .gitmodules git:// urls with newlines
The previous commit taught the clone/fetch client side to reject a
git:// URL with a newline in it. Let's also catch these when fscking a
.gitmodules file, which will give an earlier warning.
Note that it would be simpler to just complain about newline in _any_
URL, but an earlier tightening for http/ftp made sure we kept allowing
newlines for unknown protocols (and this is covered in the tests). So
we'll stick to that precedent.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The previous commit taught the clone/fetch client side to reject a
git:// URL with a newline in it. Let's also catch these when fscking a
.gitmodules file, which will give an earlier warning.
Note that it would be simpler to just complain about newline in _any_
URL, but an earlier tightening for http/ftp made sure we kept allowing
newlines for unknown protocols (and this is covered in the tests). So
we'll stick to that precedent.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| fsck.c | diffblobblamehistory | |
| t/t7416-submodule-dash-url.sh | diffblobblamehistory |