| commit | 65156bb7ec6443ba01edcff3691d878c7a04ede0 | |
| author | Elijah Newren <newren@gmail.com> | |
| Tue, 11 Apr 2023 07:42:02 +0000 (11 00:42 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 11 Apr 2023 15:52:11 +0000 (11 08:52 -0700) | ||
| tree | 94eb5ab30837aa68ee73459584677f9b55fc1792 | treesnapshot (tar.gz zip) |
| parent | 31dfa17b3b83fcf0ff8ba286167b4225dc7d480d | commitdiff |
treewide: remove double forward declaration of read_in_full
cache.h's nature of a dumping ground of includes prevented it from
being included in some compat/ files, forcing us into a workaround
of having a double forward declaration of the read_in_full() function
(see commit 14086b0a13 ("compat/pread.c: Add a forward declaration to
fix a warning", 2007-11-17)). Now that we have moved functions like
read_in_full() from cache.h to wrapper.h, and wrapper.h isn't littered
with unrelated and scary #defines, get rid of the extra forward
declaration and just have compat/pread.c include wrapper.h.
Signed-off-by: Elijah Newren <newren@gmail.com>
Acked-by: Calvin Wan <calvinwan@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
cache.h's nature of a dumping ground of includes prevented it from
being included in some compat/ files, forcing us into a workaround
of having a double forward declaration of the read_in_full() function
(see commit 14086b0a13 ("compat/pread.c: Add a forward declaration to
fix a warning", 2007-11-17)). Now that we have moved functions like
read_in_full() from cache.h to wrapper.h, and wrapper.h isn't littered
with unrelated and scary #defines, get rid of the extra forward
declaration and just have compat/pread.c include wrapper.h.
Signed-off-by: Elijah Newren <newren@gmail.com>
Acked-by: Calvin Wan <calvinwan@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 files changed: