| commit | 5269f7f8c6b293f1568c4f03c14596835e22df31 | |
| author | Ramkumar Ramachandra <artagnon@gmail.com> | |
| Sun, 2 Jun 2013 14:03:42 +0000 (2 19:33 +0530) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 9 Jun 2013 22:56:35 +0000 (9 15:56 -0700) | ||
| tree | 8c211fa92c409a9598e5866afc114d8f72dc5407 | treesnapshot (tar.gz zip) |
| parent | d8517cc6670d4ba18e9b77a83b2481aec0edbc32 | commitdiff |
completion: show can take both revlist and paths
The 'git show' completion uses __git_complete_file (aliased to
__git_complete_revlist_file), because accepts <tree-ish>:<path> as
well as <commit-ish>. But the command also accepts range of commits
in A..B notation, so using __git_complete_revlist_file is more
appropriate.
There still remain two users of __git_complete_file, completions for
"archive" and "ls-tree". As these commands do not take range
notation, and "git show" no longer uses __git_complete_file, the
implementation of it can be updated not to complete ranges, but that
is a separate topic.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The 'git show' completion uses __git_complete_file (aliased to
__git_complete_revlist_file), because accepts <tree-ish>:<path> as
well as <commit-ish>. But the command also accepts range of commits
in A..B notation, so using __git_complete_revlist_file is more
appropriate.
There still remain two users of __git_complete_file, completions for
"archive" and "ls-tree". As these commands do not take range
notation, and "git show" no longer uses __git_complete_file, the
implementation of it can be updated not to complete ranges, but that
is a separate topic.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/completion/git-completion.bash | diffblobblamehistory |