| commit | 4a14f8d093138a313070fd6a50204eda66c1f9eb | |
| author | Michael Haggerty <mhagger@alum.mit.edu> | |
| Wed, 24 Jan 2018 11:14:13 +0000 (24 12:14 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 24 Jan 2018 20:55:26 +0000 (24 12:55 -0800) | ||
| tree | dd2a8d461a25cc336cdcf2ce0e7f351dbdaf0a7c | treesnapshot (tar.gz zip) |
| parent | 27a41841ec7f83b3b1078c400f149bc536e796a4 | commitdiff |
find_reference_location(): make function safe for empty snapshots
This function had two problems if called for an empty snapshot (i.e.,
`snapshot->start == snapshot->eof == NULL`):
* It checked `NULL < NULL`, which is undefined by C (albeit highly
unlikely to fail in the real world).
* (Assuming the above comparison behaved as expected), it returned
NULL when `mustexist` was false, contrary to its docstring.
Change the check and fix the docstring.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This function had two problems if called for an empty snapshot (i.e.,
`snapshot->start == snapshot->eof == NULL`):
* It checked `NULL < NULL`, which is undefined by C (albeit highly
unlikely to fail in the real world).
* (Assuming the above comparison behaved as expected), it returned
NULL when `mustexist` was false, contrary to its docstring.
Change the check and fix the docstring.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| refs/packed-backend.c | diffblobblamehistory |