| commit | 482d5499067b2a1fc8d1ebfb5160022dc23ab136 | |
| author | Patrick Steinhardt <ps@pks.im> | |
| Fri, 23 Apr 2021 05:47:15 +0000 (23 07:47 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 27 Apr 2021 06:15:34 +0000 (27 15:15 +0900) | ||
| tree | 81ce36e19f0fb858f45398d21edd52664ebe7d1c | treesnapshot (tar.gz zip) |
| parent | 4179b4897f2de28858acaebd6382c06c91532e98 | commitdiff |
t1300: fix unset of GIT_CONFIG_NOSYSTEM leaking into subsequent tests
In order to test whether the new GIT_CONFIG_SYSTEM environment variable
behaves as expected, we unset GIT_CONFIG_NOSYSTEM in one of our tests in
t1300. But because tests are not executed in a subshell, this unset
leaks into all subsequent tests and may thus cause them to fail in some
environments. These failures are easily reproducable with `make
prefix=/root test`.
Fix the issue by not using `sane_unset GIT_CONFIG_NOSYSTEM`, but instead
just manually add it to the environment of the two command invocations
which need it.
Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In order to test whether the new GIT_CONFIG_SYSTEM environment variable
behaves as expected, we unset GIT_CONFIG_NOSYSTEM in one of our tests in
t1300. But because tests are not executed in a subshell, this unset
leaks into all subsequent tests and may thus cause them to fail in some
environments. These failures are easily reproducable with `make
prefix=/root test`.
Fix the issue by not using `sane_unset GIT_CONFIG_NOSYSTEM`, but instead
just manually add it to the environment of the two command invocations
which need it.
Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t1300-config.sh | diffblobblamehistory |