range-diff: fix regression in passing along diff options
commit4624185a67aa17104762a4bbff2b05727ef4cd83
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 9 Nov 2018 10:18:02 +0000 (9 10:18 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 12 Nov 2018 03:09:21 +0000 (12 12:09 +0900)
tree54f669ec755a6e3ea7007b80fc7ac7d0f36c24c9
parentdf569c3f31f4aab5f9fd003029090a321bacd2bd
range-diff: fix regression in passing along diff options

In 73a834e9e2 ("range-diff: relieve callers of low-level configuration
burden", 2018-07-22) we broke passing down options like --no-patch,
--stat etc.

Fix that regression, and add a test asserting the pre-73a834e9e2
behavior for some of these diff options.

As noted in a change leading up to this ("range-diff doc: add a
section about output stability", 2018-11-07) the output is not meant
to be stable. So this regression test will likely need to be tweaked
once we get a "proper" --stat option.

See
https://public-inbox.org/git/nycvar.QRO.7.76.6.1811071202480.39@tvgsbejvaqbjf.bet/
for a further explanation of the regression. The fix here is not the
same as in Johannes's on-list patch, for reasons that'll be explained
in a follow-up commit.

The quoting of "EOF" here mirrors that of an earlier test. Perhaps
that should be fixed, but let's leave that up to a later cleanup
change.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
range-diff.c
t/t3206-range-diff.sh