| commit | 45d4bdae5906cfe6b7cb1ba1cec82fd80381e07e | |
| author | Jeff King <peff@peff.net> | |
| Mon, 25 Mar 2013 20:16:50 +0000 (25 16:16 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 27 Mar 2013 20:46:47 +0000 (27 13:46 -0700) | ||
| tree | 1ff97a633a56df704998bdc7ec41c15ee18e05fa | treesnapshot (tar.gz zip) |
| parent | 7632cd274464d693c3821205f72a54cda2b7d83b | commitdiff |
stream_blob_to_fd: detect errors reading from stream
We call read_istream, but never check its return value for
errors. This can lead to us looping infinitely, as we just
keep trying to write "-1" bytes (and we do not notice the
error, as we simply check that write_in_full reports the
same number of bytes we fed it, which of course is also -1).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We call read_istream, but never check its return value for
errors. This can lead to us looping infinitely, as we just
keep trying to write "-1" bytes (and we do not notice the
error, as we simply check that write_in_full reports the
same number of bytes we fed it, which of course is also -1).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| streaming.c | diffblobblamehistory |