| commit | 431f4a26b5a8371de64776028ea511c79f74296a | |
| author | Eric Sunshine <sunshine@sunshineco.com> | |
| Mon, 2 Jul 2018 00:23:48 +0000 (1 20:23 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 3 Jul 2018 19:38:05 +0000 (3 12:38 -0700) | ||
| tree | 19dcc708516709a47c56d7f00b64aaa8e11ec266 | treesnapshot (tar.gz zip) |
| parent | fb23bd7af232d05d415653dc4d80b634a428f76f | commitdiff |
t5505: modernize and simplify hard-to-digest test
This test uses a subshell within a subshell but is formatted in such a
way as to suggests that the inner subshell is a sibling rather than a
child, which makes it difficult to digest the test's structure and
intent.
Worse, the inner subshell performs cleanup of actions from earlier in
the test, however, a failure between the initial actions and the cleanup
will prevent the cleanup from taking place.
Fix these problems by modernizing and simplifying the test and by using
test_when_finished() for the cleanup action.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This test uses a subshell within a subshell but is formatted in such a
way as to suggests that the inner subshell is a sibling rather than a
child, which makes it difficult to digest the test's structure and
intent.
Worse, the inner subshell performs cleanup of actions from earlier in
the test, however, a failure between the initial actions and the cleanup
will prevent the cleanup from taking place.
Fix these problems by modernizing and simplifying the test and by using
test_when_finished() for the cleanup action.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t5505-remote.sh | diffblobblamehistory |