| commit | 3f5ef95b5e0cc0cbff06f747ba056e132a71033a | |
| author | Martin Ågren <martin.agren@gmail.com> | |
| Sat, 9 Sep 2017 06:57:17 +0000 (9 08:57 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 10 Sep 2017 07:36:58 +0000 (10 16:36 +0900) | ||
| tree | 5ef5e9112b74b792cc439caf88b66a51287fda14 | treesnapshot (tar.gz zip) |
| parent | 851e1fbd01250f56a6e479e1addada220a56e1f7 | commitdiff |
refs/files-backend: correct return value in lock_ref_for_update
In one code path we return a literal -1 and not a symbolic constant. The
value -1 would be interpreted as TRANSACTION_NAME_CONFLICT, which is
wrong. Use TRANSACTION_GENERIC_ERROR instead (that is the only other
return value we have to choose from).
Noticed-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In one code path we return a literal -1 and not a symbolic constant. The
value -1 would be interpreted as TRANSACTION_NAME_CONFLICT, which is
wrong. Use TRANSACTION_GENERIC_ERROR instead (that is the only other
return value we have to choose from).
Noticed-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| refs/files-backend.c | diffblobblamehistory |