t0066: drop setup of "dir5"
commit3b0ebb7a8db6e5a1a11dcb2c1f549e4d6037185c
authorJeff King <peff@peff.net>
Fri, 17 Feb 2023 00:40:29 +0000 (16 19:40 -0500)
committerJunio C Hamano <gitster@pobox.com>
Fri, 17 Feb 2023 01:55:42 +0000 (16 17:55 -0800)
treee023213920c62e04b4b4f43f075af33e8fb11c61
parente00e56a7df616659c90d107c3d31d362b5dff103
t0066: drop setup of "dir5"

The symlink setup in t0066 makes several directories with links, dir4
through dir6. But ever since dir5 was introduced in fa1da7d2ee
(dir-iterator: add flags parameter to dir_iterator_begin, 2019-07-10),
it has never actually been used. It was left over from an earlier
iteration of the patch which tried to handle recursive symlinks
specially, as seen in:

  https://lore.kernel.org/git/20190502144829.4394-7-matheus.bernardino@usp.br/

It's not hurting any of the existing tests to be there, but the extra
setup is confusing to anybody trying to read and understand the tests.
Let's drop the extra directory, and we'll rename "dir6" to "dir5" so
nobody wonders whether the gap in naming is important.

Helped-by: Matheus Tavares Bernardino <matheus.tavb@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t0066-dir-iterator.sh