| commit | 3afaa72d7d4e52d5fa1bc19abb68301f2b09aca6 | |
| author | Junio C Hamano <junkio@cox.net> | |
| Sun, 4 Mar 2007 08:17:27 +0000 (4 00:17 -0800) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sun, 4 Mar 2007 08:17:27 +0000 (4 00:17 -0800) | ||
| tree | 27ced0c124fc0bcf1869cdd2bbe84394f219114d | treesnapshot (tar.gz zip) |
| parent | 5332b2af104180b8135e0b3528ace7596cb9ba09 | commitdiff |
diff-ni: fix the diff with standard input
The earlier commit to read from stdin was full of problems, and
this corrects them.
- The mode bits should have been set to satisify S_ISREG(); we
forgot to the S_IFREG bits and hardcoded 0644;
- We did not give escape hatch to name a path whose name is
really "-". Allow users to say "./-" for that;
- Use of xread() was not prepared to see short read (e.g. reading
from tty) nor handing read errors.
Signed-off-by: Junio C Hamano <junkio@cox.net>
The earlier commit to read from stdin was full of problems, and
this corrects them.
- The mode bits should have been set to satisify S_ISREG(); we
forgot to the S_IFREG bits and hardcoded 0644;
- We did not give escape hatch to name a path whose name is
really "-". Allow users to say "./-" for that;
- Use of xread() was not prepared to see short read (e.g. reading
from tty) nor handing read errors.
Signed-off-by: Junio C Hamano <junkio@cox.net>
| diff-lib.c | diffblobblamehistory | |
| diff.c | diffblobblamehistory |