| commit | 35f070b4de8fa01c11d9478297ea074d633bd7d5 | |
| author | Phillip Wood <phillip.wood@dunelm.org.uk> | |
| Tue, 21 Sep 2021 10:24:05 +0000 (21 10:24 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 22 Sep 2021 19:04:51 +0000 (22 12:04 -0700) | ||
| tree | 85cd932e88da3a48f7d994a548975917df134567 | treesnapshot (tar.gz zip) |
| parent | d045719ac8ab2b2c6f4d7ce61ad3d35843556bbf | commitdiff |
rebase: use our standard error return value
Git uses −1 to signal an error. The builtin rebase converts these to
+1 all over the place using !! (presumably because the in the scripted
version an error was signalled by +1). This is confusing and clutters
the code, we only need to convert the value when the function returns.
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Git uses −1 to signal an error. The builtin rebase converts these to
+1 all over the place using !! (presumably because the in the scripted
version an error was signalled by +1). This is confusing and clutters
the code, we only need to convert the value when the function returns.
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/rebase.c | diffblobblamehistory |