| commit | 331b094eec6d4c937af6e59df2a537112e4d8205 | |
| author | Elijah Newren <newren@gmail.com> | |
| Sun, 16 Apr 2023 03:03:05 +0000 (16 03:03 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 18 Apr 2023 21:01:04 +0000 (18 14:01 -0700) | ||
| tree | 38b6c65c15b9e719d026cd68917227920f78e268 | treesnapshot (tar.gz zip) |
| parent | 4711556905f381c01f1fbae205f67cfa673ab44a | commitdiff |
protocol.h: move definition of DEFAULT_GIT_PORT from cache.h
Michael J Gruber noticed that connection via the git:// protocol no
longer worked after a recent header clean-up. This was caused by
funny interaction of few gotchas. First, a necessary definition
#define DEFAULT_GIT_PORT 9418
was made invisible to a place where
const char *port = STR(DEFAULT_GIT_PORT);
was expecting to turn the integer into "9418" with a clever STR()
macro, and ended up stringifying it to
const char *port = "DEFAULT_GIT_PORT";
without giving any chance to compilers to notice such a mistake.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michael J Gruber noticed that connection via the git:// protocol no
longer worked after a recent header clean-up. This was caused by
funny interaction of few gotchas. First, a necessary definition
#define DEFAULT_GIT_PORT 9418
was made invisible to a place where
const char *port = STR(DEFAULT_GIT_PORT);
was expecting to turn the integer into "9418" with a clever STR()
macro, and ended up stringifying it to
const char *port = "DEFAULT_GIT_PORT";
without giving any chance to compilers to notice such a mistake.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| cache.h | diffblobblamehistory | |
| daemon.c | diffblobblamehistory | |
| protocol.h | diffblobblamehistory |