each_ref_fn: change to take an object_id parameter
commit2b2a5be394bc67bed86bc009195c664dca740bd6
authorMichael Haggerty <mhagger@alum.mit.edu>
Mon, 25 May 2015 18:38:28 +0000 (25 18:38 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 25 May 2015 19:19:27 +0000 (25 12:19 -0700)
tree695bba8905d3f1d806ab329e65d2a297abfc85ac
parent8353847e85128e0d0bbed862889f6f36c608c73b
each_ref_fn: change to take an object_id parameter

Change typedef each_ref_fn to take a "const struct object_id *oid"
parameter instead of "const unsigned char *sha1".

To aid this transition, implement an adapter that can be used to wrap
old-style functions matching the old typedef, which is now called
"each_ref_sha1_fn"), and make such functions callable via the new
interface. This requires the old function and its cb_data to be
wrapped in a "struct each_ref_fn_sha1_adapter", and that object to be
used as the cb_data for an adapter function, each_ref_fn_adapter().

This is an enormous diff, but most of it consists of simple,
mechanical changes to the sites that call any of the "for_each_ref"
family of functions. Subsequent to this change, the call sites can be
rewritten one by one to use the new interface.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
36 files changed:
Documentation/technical/api-ref-iteration.txt
bisect.c
builtin/branch.c
builtin/checkout.c
builtin/describe.c
builtin/fetch.c
builtin/for-each-ref.c
builtin/fsck.c
builtin/name-rev.c
builtin/pack-objects.c
builtin/receive-pack.c
builtin/reflog.c
builtin/remote.c
builtin/replace.c
builtin/rev-parse.c
builtin/show-branch.c
builtin/show-ref.c
builtin/tag.c
fetch-pack.c
help.c
http-backend.c
log-tree.c
notes.c
reachable.c
refs.c
refs.h
remote.c
replace_object.c
revision.c
server-info.c
sha1_name.c
shallow.c
submodule.c
transport.c
upload-pack.c
walker.c