| commit | 24942ef31636f5e1f8076454200be76db8740848 | |
| author | Jeff King <peff@peff.net> | |
| Thu, 7 Dec 2023 07:11:24 +0000 (7 02:11 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 8 Dec 2023 23:24:47 +0000 (9 08:24 +0900) | ||
| tree | d13845edead9bf9b60f643dafefdc2c22b771ec4 | treesnapshot (tar.gz zip) |
| parent | a62712696e76eddebf9b5e0ecf2c9040558584bb | commitdiff |
trace2: handle NULL values in tr2_sysenv config callback
If you have config with an implicit bool like:
[trace2]
envvars
we'll segfault, as we unconditionally try to xstrdup() the value. We
should instead detect and complain, as a boolean value has no meaning
here. The same is true for every variable in tr2_sysenv_settings (and
this patch covers them all, as we check them in a loop).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
If you have config with an implicit bool like:
[trace2]
envvars
we'll segfault, as we unconditionally try to xstrdup() the value. We
should instead detect and complain, as a boolean value has no meaning
here. The same is true for every variable in tr2_sysenv_settings (and
this patch covers them all, as we check them in a loop).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| trace2/tr2_sysenv.c | diffblobblamehistory |