| commit | 1f5db32d89b62317cf59486d14e8b2d4d004cd1e | |
| author | Jeff King <peff@peff.net> | |
| Mon, 5 Nov 2018 06:43:12 +0000 (5 01:43 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 6 Nov 2018 03:55:36 +0000 (6 12:55 +0900) | ||
| tree | 32059d602faa6a6562995646d9a24f43dae78506 | treesnapshot (tar.gz zip) |
| parent | 403d2ba52cb63d4bf5a8baf5480efc538f405c09 | commitdiff |
tag: mark "--message" option with NONEG
We do not allow "--no-message" to work now, as the option callback
returns "-1" when it sees a NULL arg. However, that will cause
parse-options to exit(129) without printing anything further, leaving
the user confused about what happened.
Instead, let's explicitly mark it as PARSE_OPT_NONEG, which will give a
useful error message (and print the usual -h output).
In theory this could be used to override an earlier "-m", but it's not
clear how it would interact with other message options (e.g., would it
also clear data read for "-F"?). Since it's already disabled and nobody
is asking for it, let's punt on that and just improve the error message.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We do not allow "--no-message" to work now, as the option callback
returns "-1" when it sees a NULL arg. However, that will cause
parse-options to exit(129) without printing anything further, leaving
the user confused about what happened.
Instead, let's explicitly mark it as PARSE_OPT_NONEG, which will give a
useful error message (and print the usual -h output).
In theory this could be used to override an earlier "-m", but it's not
clear how it would interact with other message options (e.g., would it
also clear data read for "-F"?). Since it's already disabled and nobody
is asking for it, let's punt on that and just improve the error message.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/tag.c | diffblobblamehistory |