| commit | 1d0538e4860f3827bb711a4a05dbc2f194f767be | |
| author | Jeff King <peff@peff.net> | |
| Wed, 6 Sep 2017 11:53:10 +0000 (6 07:53 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 6 Sep 2017 23:46:53 +0000 (7 08:46 +0900) | ||
| tree | da7dda784ddcd63e71801a1759ccab19f6470d6d | treesnapshot (tar.gz zip) |
| parent | 03df567fbf6afeca32f6a27d04656c1a3a162453 | commitdiff |
rev-parse: don't trim bisect refnames
Using for_each_ref_in() with a full refname has always been
a questionable practice, but it became an error with
b9c8e7f2fb (prefix_ref_iterator: don't trim too much,
2017-05-22), making "git rev-parse --bisect" pretty reliably
show a BUG.
Commit 03df567fbf (for_each_bisect_ref(): don't trim
refnames, 2017-06-18) fixed this case for revision.c, but
rev-parse handles this option on its own. We can use the
same solution here (and piggy-back on its test).
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Using for_each_ref_in() with a full refname has always been
a questionable practice, but it became an error with
b9c8e7f2fb (prefix_ref_iterator: don't trim too much,
2017-05-22), making "git rev-parse --bisect" pretty reliably
show a BUG.
Commit 03df567fbf (for_each_bisect_ref(): don't trim
refnames, 2017-06-18) fixed this case for revision.c, but
rev-parse handles this option on its own. We can use the
same solution here (and piggy-back on its test).
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/rev-parse.c | diffblobblamehistory | |
| t/t6002-rev-list-bisect.sh | diffblobblamehistory |