| commit | 0b0ecaac2ad984599923999d6d4c32e6111bb73f | |
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | |
| Mon, 21 Jan 2013 13:00:49 +0000 (21 20:00 +0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 22 Jan 2013 00:57:38 +0000 (21 16:57 -0800) | ||
| tree | c562068adb24c8321271e48dd94fb45685a7d5c6 | treesnapshot (tar.gz zip) |
| parent | 4db86e8b6e8002b3113341ad742bf2fd94d4df50 | commitdiff |
grep: avoid accepting ambiguous revision
Unlike other commands that take both revs and pathspecs without "--"
disamiguators only when the boundary is clear, "git grep" treated
what can be interpreted as a rev as-is, without making sure that it
could also have meant a pathspec. E.g.
$ git grep -e foo master
when 'master' is in the working tree, should have triggered an
ambiguity error, but it didn't, and searched in the tree of the
commit named by 'master'.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Unlike other commands that take both revs and pathspecs without "--"
disamiguators only when the boundary is clear, "git grep" treated
what can be interpreted as a rev as-is, without making sure that it
could also have meant a pathspec. E.g.
$ git grep -e foo master
when 'master' is in the working tree, should have triggered an
ambiguity error, but it didn't, and searched in the tree of the
commit named by 'master'.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/grep.c | diffblobblamehistory |