find_hook: keep our own static buffer
commit03f2c7731b59de75357730bc511ffa8847e1fb81
authorJeff King <peff@peff.net>
Mon, 10 Aug 2015 09:37:45 +0000 (10 05:37 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 10 Aug 2015 22:37:13 +0000 (10 15:37 -0700)
treedc1ffb12f1ab50f46c811b73402ce5beca71c45b
parent470e28d4e16dd994cd985914377fa8ccb5f86227
find_hook: keep our own static buffer

The find_hook function returns the results of git_path,
which is a static buffer shared by other path-related calls.
Returning such a buffer is slightly dangerous, because it
can be overwritten by seemingly unrelated functions.

Let's at least keep our _own_ static buffer, so you can
only get in trouble by calling find_hook in quick
succession, which is less likely to happen and more obvious
to notice.

While we're at it, let's add some documentation of the
function's limitations.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
run-command.c
run-command.h