| commit | 037714252f74ae77e816018e43b2504a1b057246 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Fri, 15 Jun 2018 18:13:39 +0000 (15 11:13 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 15 Jun 2018 18:20:08 +0000 (15 11:20 -0700) | ||
| tree | b50cad99709711c60d673be889481447226930e3 | treesnapshot (tar.gz zip) |
| parent | fc54c1af3ec09bab8b8ea09768c2da4069b7f53e | commitdiff |
tests: clean after SANITY tests
Some of our tests try to make sure Git behaves sensibly in a
read-only directory, by dropping 'w' permission bit before doing a
test and then restoring it after it is done. The latter is needed
for the test framework to clean after itself without leaving a
leftover directory that cannot be removed.
Ancient parts of tests however arrange the above with
chmod a-w . &&
... do the test ...
status=$?
chmod 775 .
(exit $status)
which obviously would not work if the test somehow dies before it
has the chance to do "chmod 775". Rewrite them by following a more
robust pattern recently written tests use, which is
test_when_finished "chmod 775 ." &&
chmod a-w . &&
... do the test ...
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Some of our tests try to make sure Git behaves sensibly in a
read-only directory, by dropping 'w' permission bit before doing a
test and then restoring it after it is done. The latter is needed
for the test framework to clean after itself without leaving a
leftover directory that cannot be removed.
Ancient parts of tests however arrange the above with
chmod a-w . &&
... do the test ...
status=$?
chmod 775 .
(exit $status)
which obviously would not work if the test somehow dies before it
has the chance to do "chmod 775". Rewrite them by following a more
robust pattern recently written tests use, which is
test_when_finished "chmod 775 ." &&
chmod a-w . &&
... do the test ...
Signed-off-by: Junio C Hamano <gitster@pobox.com>