| commit | 5f8b70b1dc3d149782564e04d5d55565a5157d93 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Fri, 26 Jan 2007 02:33:06 +0000 (25 21:33 -0500) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Fri, 26 Jan 2007 05:41:01 +0000 (26 00:41 -0500) | ||
| tree | 06c4c262fc7f602744d2bd02bb9b17afa6448724 | treesnapshot (tar.gz zip) |
| parent | d070c4cb17e807c157aaeb24d9b80a1112334e57 | commitdiff |
git-gui: Maintain the same file list for diff during refresh.
I just noticed that a file was always jumping to compare against HEAD
and the index during a refresh, even if the diff viewer was comparing
the index against the working directory prior to the refresh. The
bug turned out to be caused by a foreach loop going through all file
list names searching for the path. Since $ui_index was the first one
searched and the file was contained in that file list the loop broke
out, leaving $w set to $ui_index when it had been set by the caller
to $ui_workdir. Silly bug caused by using a parameter as a loop
index.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
I just noticed that a file was always jumping to compare against HEAD
and the index during a refresh, even if the diff viewer was comparing
the index against the working directory prior to the refresh. The
bug turned out to be caused by a foreach loop going through all file
list names searching for the path. Since $ui_index was the first one
searched and the file was contained in that file list the loop broke
out, leaving $w set to $ui_index when it had been set by the caller
to $ui_workdir. Silly bug caused by using a parameter as a loop
index.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| git-gui.sh | diffblobblamehistory |