| commit | e670fce17f79f6305f17f2a91732565909c678dd | |
| author | Philip Oakley <philipoakley@iee.org> | |
| Mon, 14 Dec 2015 10:42:04 +0000 (14 10:42 +0000) | ||
| committer | Philip Oakley <philipoakley@iee.org> | |
| Fri, 20 Jan 2017 21:10:28 +0000 (20 21:10 +0000) | ||
| tree | 4796d613afb5a31b9eb2232518932e9d03f85e48 | treesnapshot (tar.gz zip) |
| parent | 3202c68ee0060d3a1f3b6f73b4932c6e8b263abb | commitdiff |
git gui: de-dup selected repo from recentrepo history
When the gui/user selects a repo for display, that repo is brought to
the end of the recentrepo config list. The logic can fail if there are
duplicate old entries for the repo (you cannot unset a single config
entry when duplicates are present).
Similarly, the maxrecentrepo logic could fail if older duplicate entries
are present.
The first commit of this series ({this}~2) fixed the config unsetting
issue. Rather than manipulating a local copy of the $recent list (one
cannot know how many entries were removed), simply re-read it.
We must also catch the error when the attempt to remove the second copy
from the re-read list is performed.
Signed-off-by: Philip Oakley <philipoakley@iee.org>
When the gui/user selects a repo for display, that repo is brought to
the end of the recentrepo config list. The logic can fail if there are
duplicate old entries for the repo (you cannot unset a single config
entry when duplicates are present).
Similarly, the maxrecentrepo logic could fail if older duplicate entries
are present.
The first commit of this series ({this}~2) fixed the config unsetting
issue. Rather than manipulating a local copy of the $recent list (one
cannot know how many entries were removed), simply re-read it.
We must also catch the error when the attempt to remove the second copy
from the re-read list is performed.
Signed-off-by: Philip Oakley <philipoakley@iee.org>
| lib/choose_repository.tcl | diffblobblamehistory |