| commit | 043f701116c30067c2a7096135b6e419dd1f7b47 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Sun, 12 Nov 2006 23:16:45 +0000 (12 18:16 -0500) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Mon, 13 Nov 2006 05:10:39 +0000 (13 00:10 -0500) | ||
| tree | 954ba44b1e82786fdc06ebcf5d5c5ebfead65250 | treesnapshot (tar.gz zip) |
| parent | c8ebafd84537473bb8a53880a6a6740d723b83bc | commitdiff |
git-gui: Always use eq/ne for string comparsions.
This is one of those stupid Tcl mistakes that an experienced Tcl
programmer just wouldn't make. We should always use eq and ne to
compare string values (and never == or !=) as when we use ==/!=
Tcl will attempt to convert either side to numeric if one of the
two sides looks like a numeric. This could cause some trouble if
a file named "1" exists and a different file named "1.0" also exists;
their paths are equal according to == but not according to eq.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This is one of those stupid Tcl mistakes that an experienced Tcl
programmer just wouldn't make. We should always use eq and ne to
compare string values (and never == or !=) as when we use ==/!=
Tcl will attempt to convert either side to numeric if one of the
two sides looks like a numeric. This could cause some trouble if
a file named "1" exists and a different file named "1.0" also exists;
their paths are equal according to == but not according to eq.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| git-gui | diffblobblamehistory |