From 53e98570c4110154f8ce429a2906bdd8331b139a Mon Sep 17 00:00:00 2001 From: David Aguilar Date: Tue, 2 Feb 2010 22:05:12 -0800 Subject: [PATCH] controllers.selectcommits: Do not pass string to QObject.connect() QObserver was recently reworked to not override QObject.connect(). When this happened it stopped automatically wrapping signal names with SIGNAL(). Do the mainstream Qt thing and wrap the signal name with SIGNAL(). Fixes #42 Signed-off-by: David Aguilar --- cola/controllers/selectcommits.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cola/controllers/selectcommits.py b/cola/controllers/selectcommits.py index 8df3f01c..21cd8a7f 100644 --- a/cola/controllers/selectcommits.py +++ b/cola/controllers/selectcommits.py @@ -2,6 +2,7 @@ """ from PyQt4 import QtGui +from PyQt4.QtCore import SIGNAL import cola from cola import gitcmds @@ -32,7 +33,7 @@ class SelectCommitsController(QObserver): self.model.set_summaries(summaries) self.connect(view.commit_list, - 'itemSelectionChanged()', + SIGNAL('itemSelectionChanged()'), self.commit_sha1_selected) view.commit_list.contextMenuEvent = self.context_menu_event self.set_diff_font() -- 2.11.4.GIT