| commit | bdabe8001d198a5634143bd47b797ab4f284d384 | |
| author | Kurt McKee <contactme@kurtmckee.org> | |
| Wed, 23 Aug 2023 13:19:58 +0000 (23 08:19 -0500) | ||
| committer | David Aguilar <davvid@gmail.com> | |
| Thu, 24 Aug 2023 20:41:01 +0000 (24 13:41 -0700) | ||
| tree | 25d54966dc65adde2a735f3e8fb51618d85c95d4 | treesnapshot (tar.gz zip) |
| parent | ff93c5c2f699580c2c7418924e3f23e69c83ff7b | commitdiff |
GUI: Stop making newly-created buttons immediately visible
On Windows, making a newly-created button visible causes
a new window to open containing only the new button.
Testing shows that the buttons will be visible
in whatever dock they are ultimately assigned to
when the main git-cola window opens
even if `.setVisible(True)` is not called first.
Therefore, the default `visible` value is changed to `None`,
and `.setVisible` will only be called if a bool value is specified.
Fixes #1329
(cherry picked from commit 7ff7d77463a97e69d9084c475cc1a48610541b87)
On Windows, making a newly-created button visible causes
a new window to open containing only the new button.
Testing shows that the buttons will be visible
in whatever dock they are ultimately assigned to
when the main git-cola window opens
even if `.setVisible(True)` is not called first.
Therefore, the default `visible` value is changed to `None`,
and `.setVisible` will only be called if a bool value is specified.
Fixes #1329
(cherry picked from commit 7ff7d77463a97e69d9084c475cc1a48610541b87)
| cola/qtutils.py | diffblobblamehistory |