From 4e76cdc63b44af0cbe3dab770837c68fb21b9d8e Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Wed, 21 Feb 2018 21:08:54 -0800 Subject: [PATCH] install.sh: validate $Girocco::Config::reporoot a bit more In aace95e56cf84b76 (install.sh: validate $Girocco::Config::chroot a bit more, 2017-12-12), install.sh started validating $Girocco::Config::chroot to make sure it could be used safely in GIT_ALTERNATE_OBJECT_DIRECTORIES without problems. Correct that and validate $Girocco::Config::reporoot instead as that was the originally intended check since the chroot value is not necessarily relevant to the value of GIT_ALTERNATE_OBJECT_DIRECTORIES at all. D'oh! Signed-off-by: Kyle J. McKay --- install.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/install.sh b/install.sh index 79af6ca..f10e351 100755 --- a/install.sh +++ b/install.sh @@ -28,12 +28,12 @@ perl -I. -M$GIROCCO_CONF -e '' umask 0022 "$var_perl_bin" toolbox/check-perl-modules.pl -# Config.pm already checked $cfg_chroot to require an absolute path, but +# Config.pm already checked $cfg_reporoot to require an absolute path, but # we also require it does not contain a : or ; that would cause problems when # used in GIT_ALTERNATE_OBJECT_DIRECTORIES probch=':;' -case "$cfg_chroot" in *[$probch]*) - echo "fatal: \$Girocco::Config::chroot may not contain ':' or ';' characters" >&2 +case "$cfg_reporoot" in *[$probch]*) + echo "fatal: \$Girocco::Config::reporoot may not contain ':' or ';' characters" >&2 exit 1 esac -- 2.11.4.GIT