From a6c4e6c4f3d520d2ce82b094cc18447eb12bc921 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Thu, 2 Oct 2014 04:48:03 -0700 Subject: [PATCH] editproj.cgi: actually initiate a restart when selected Since dcad805d mirrorproj.cgi no longer initiates a clone. Not only does this avoid duplicate clone requests since regproj.cgi has been initiating clones since 6a6d238a, but it avoids possible malicious behavior since mirrorproj.cgi does not require a password. However, this change leaves mirrors that need to be restarted unable to be restarted since $proj->clone never gets called. Add the necessary $proj->clone call to editproj.cgi instead so that mirrors can actually be restarted. --- cgi/editproj.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/cgi/editproj.cgi b/cgi/editproj.cgi index ca06253..50df24c 100755 --- a/cgi/editproj.cgi +++ b/cgi/editproj.cgi @@ -62,6 +62,7 @@ if (($y0 eq 'Update' || $y0 eq 'Restart Mirroring') && $cgi->request_method eq ' if ($proj->cgi_fill($gcgi) and $proj->authenticate($gcgi) and $proj->update) { print "

Project successfully updated.

\n"; if ($proj->{clone_failed}) { + $proj->clone; print "

Please pass onwards.

\n"; print "