Fix layer on/off rendering
I'm not certain this is correct at all. It works around failure
to switch layer visibility on / off after
commit 9768e060fad7bc3dfc366da76ea1db8154005018
"Fix layer visibility logic for some boards."
After which, copper layers on the component / solder group
would still be drawn unless the silk layer was also turned off.
This appears to be due to the GL HID's custom drawing routines
not checking the return of the (HID)->set_layer function in certain
instances.
This fix is almost certainly WRONG.
I'm not certain this is correct at all. It works around failure
to switch layer visibility on / off after
commit 9768e060fad7bc3dfc366da76ea1db8154005018
"Fix layer visibility logic for some boards."
After which, copper layers on the component / solder group
would still be drawn unless the silk layer was also turned off.
This appears to be due to the GL HID's custom drawing routines
not checking the return of the (HID)->set_layer function in certain
instances.
This fix is almost certainly WRONG.
Draw pin / pad names first, so they don't get masked by the pad
Since we use stencil masking to ensure we don't redraw an area
multiple times, confusingly, we need to draw the text first to
ensure it isn't occluded by the pad its-self.
HACK:
We probably draw the names multiple times - as we still use the
common draw.c code which assumes it can draw labels on top of
the pads.
Since we use stencil masking to ensure we don't redraw an area
multiple times, confusingly, we need to draw the text first to
ensure it isn't occluded by the pad its-self.
HACK:
We probably draw the names multiple times - as we still use the
common draw.c code which assumes it can draw labels on top of
the pads.
gtk/gl: Play with layer translucency
Major re-write to drawing routines
FIXME: FULLY OF NASTY API HACKS TO draw.c
Notes from squashed patches:
Pin and via hole cores are drawn in the appropriate colour
Playing with stack rendering order
Fix mask display in 3D (Allow both side masks to display at once)
Fix rendering depths for silk and mask layers
Fixup depth for layers and element marks
Move more rendering to world coordinates
Fix get_coords function
FIXME: FULLY OF NASTY API HACKS TO draw.c
Notes from squashed patches:
Pin and via hole cores are drawn in the appropriate colour
Playing with stack rendering order
Fix mask display in 3D (Allow both side masks to display at once)
Fix rendering depths for silk and mask layers
Fixup depth for layers and element marks
Move more rendering to world coordinates
Fix get_coords function
TMP FIXES
Fix outline drawing to only apply on copper layers
This matches comments in the code, and fixes (removes) outline drawing
on the solder mask prints.
This partially reverts commit 294494e56695251e63c0da9f243d6f59447f1c9f
"Fix PS rect/outline logic"
This matches comments in the code, and fixes (removes) outline drawing
on the solder mask prints.
This partially reverts commit 294494e56695251e63c0da9f243d6f59447f1c9f
"Fix PS rect/outline logic"
DRAW_FUNCS: Attempt at different render order for PCB+GL
Shiny 3D eye-candy
Experiments in progress - don't expect this to work yet!
Squashed:
Fix grid extents in 3D view
Experiments in progress - don't expect this to work yet!
Squashed:
Fix grid extents in 3D view
Use trackball to allow rotation of 3D view
Add virtual trackball code
hid/gtk: Add feature to force an immediate redraw if framerate is low
If more than a certain time (currently hard-coded at 50ms) has elapsed
since the last expose callback, invalidate_all() will wait and process
updates before returning.
This is handy to allow animation of auto-router progress, where the gui
mainloop is not hit until the auto-routing operation is fully complete.
If more than a certain time (currently hard-coded at 50ms) has elapsed
since the last expose callback, invalidate_all() will wait and process
updates before returning.
This is handy to allow animation of auto-router progress, where the gui
mainloop is not hit until the auto-routing operation is fully complete.
Crasy test
draw.c: Expose some drawing APIs for the HIDs to use directly...
Exposes:
DrawLayerGroup
DrawPaste
DrawSilk
DrawMask
DrawHoles
PrintAssembly
Exposes:
DrawLayerGroup
DrawPaste
DrawSilk
DrawMask
DrawHoles
PrintAssembly
hid/gtk: Fix styling of menubar area so it is consistent across its width
This relies on some nasty tricks copying GtkStyle's between the menubar
widget and a new GtkEventBox widget we pack the top bar in to give us a
background to paint on. We also adjust the styles of the coordinate read-
out labels and frames to ensure they are legible.
There may still be some inconsistencies, as the coordinate selector button
is themed as if it were a toolbar button, hence the colourings used may
be designed to work with a different background colour than we have.
This relies on some nasty tricks copying GtkStyle's between the menubar
widget and a new GtkEventBox widget we pack the top bar in to give us a
background to paint on. We also adjust the styles of the coordinate read-
out labels and frames to ensure they are legible.
There may still be some inconsistencies, as the coordinate selector button
is themed as if it were a toolbar button, hence the colourings used may
be designed to work with a different background colour than we have.
hid/gtk: Create a GtkToolbar of mode buttons for compact vertical mode
Rather than packing our mode buttons into an hbox, use a proper GtkToolbar
so theming will match the rest of the user's desktop.
This simplifies code to switch compact mode on and off, as we have two
distinct widgets to show / hide, rather than having to reparent the mode
buttons each time.
It does, however mean we have to be careful not to double-trigger events
when keeping the two sets of mode buttons in sync with each other, so that
isn't ideal.
In the longer term, we probably ought to split out the mode button area
on the left-hand toolbar as a separate self-contained widget.
Rather than packing our mode buttons into an hbox, use a proper GtkToolbar
so theming will match the rest of the user's desktop.
This simplifies code to switch compact mode on and off, as we have two
distinct widgets to show / hide, rather than having to reparent the mode
buttons each time.
It does, however mean we have to be careful not to double-trigger events
when keeping the two sets of mode buttons in sync with each other, so that
isn't ideal.
In the longer term, we probably ought to split out the mode button area
on the left-hand toolbar as a separate self-contained widget.
gtk: Prelight toggle swatches in layer selector
This brightens the layer visibility swatches subtly when the
mouse hovers over them. IMHO this improves the discoverability
of the widget without being distracting or misleading.
This brightens the layer visibility swatches subtly when the
mouse hovers over them. IMHO this improves the discoverability
of the widget without being distracting or misleading.
gtk: Don't gray out invisible layers' text in the selector
gtk: toggle non-activatable layers on click, without checking for swatch
hid/gtk: Remove compact_vbox and compact_hbox
hid/gtk: Always show the PCB name on the title-bar, not the toolbar
This saves space and reduces code complexity
This saves space and reduces code complexity
hid/gtk: Don't use a GtkEventBox as a container widget
We weren't making use of the events from the event box, and appeared
just to be using it as a convenient container to allow setting the
sensitivity on our entire left hand toolbar at once.
Scrap the event box widget and just store a pointer to the vbox widget
which the left toobar items are packed into. We can set the sensitivity
on this and get the desired effect.
We weren't making use of the events from the event box, and appeared
just to be using it as a convenient container to allow setting the
sensitivity on our entire left hand toolbar at once.
Scrap the event box widget and just store a pointer to the vbox widget
which the left toobar items are packed into. We can set the sensitivity
on this and get the desired effect.
hid/gtk: Don't pack the drawing area in a GtkViewport widget
(For both the main window and the pinout preview). The GtkViewport
widget is designed to add scroll bars to a widget which doesn't have
native scroll capabilities. We are handling out own scroll-bars, so
the only gain we had from the GtkViewport we added was a shadow
around the widget.
If we decide we want the shadow back, a more appropriate widget to
pack the drawing area with might be a GtkFrame.
(For both the main window and the pinout preview). The GtkViewport
widget is designed to add scroll bars to a widget which doesn't have
native scroll capabilities. We are handling out own scroll-bars, so
the only gain we had from the GtkViewport we added was a shadow
around the widget.
If we decide we want the shadow back, a more appropriate widget to
pack the drawing area with might be a GtkFrame.
hid/gtk: Remove the vbox used to pack ghidgui->compact_hbox
The main effect here is that the contents of the compact_hbox
will get more vertical space assigned to them if the menu bar
section is taller than the natural size of those widgets.
The visual change seems acceptable, and we could use every bit of
code-cleanup in ghid_build_pcb_top_window()
The main effect here is that the contents of the compact_hbox
will get more vertical space assigned to them if the menu bar
section is taller than the natural size of those widgets.
The visual change seems acceptable, and we could use every bit of
code-cleanup in ghid_build_pcb_top_window()
hid/gtk: Remove some more temporary variable assignments
These make the code harder to follow, as the same temporary variable
is used again and again to refer to different widgets.
These make the code harder to follow, as the same temporary variable
is used again and again to refer to different widgets.
hid/gtk: Don't use an hbox to pack the board name label
The hbox only has one child, so use the name label directly.
The hbox only has one child, so use the name label directly.
hid/gtk: Skip the generic "hbox" variable when storing the widget anyway
For widgets we keep references to in the ghidgui structure, we avoid
confusion by assigning directly to the more descriptive ghidgui variable.
For widgets we keep references to in the ghidgui structure, we avoid
confusion by assigning directly to the more descriptive ghidgui variable.
hid/gtk: Don't pack a frame around the menu bar
Move make_route_string() from gtk into misc.c
Const-correct StripWhiteSpaceAndDup in mymem.c
hid/gtk: Attempt to fix logic to flip component / solder group visibility on flip
Should get back to better behaviour. I probably broke this somewhat with
commit f903b4be6b85efc110852f7be40edf8245f0a513, which attempted to
re-state the previous logic in a clearer fashon.
The logic now should:
If flipping sides, and only ONE of the solder / component layers (groups)
is visible, and that layer (group) is _active_, then swap the visibilities
of the component / solder layers (groups), and make the newly visible
layer (group) active.
There are still bugs in this code relating to the assumption that the
first entry in the layer group is the one which is being toggled. This
breaks if the first entry in the group is that corresponding to the silk
for that side of the board.
Should get back to better behaviour. I probably broke this somewhat with
commit f903b4be6b85efc110852f7be40edf8245f0a513, which attempted to
re-state the previous logic in a clearer fashon.
The logic now should:
If flipping sides, and only ONE of the solder / component layers (groups)
is visible, and that layer (group) is _active_, then swap the visibilities
of the component / solder layers (groups), and make the newly visible
layer (group) active.
There are still bugs in this code relating to the assumption that the
first entry in the layer group is the one which is being toggled. This
breaks if the first entry in the group is that corresponding to the silk
for that side of the board.
gtk: fix typo preventing layer selector menu items from working
gtk: remove in_toggle_view recursion-prevention flag
We don't call ToggleView programmatically anywhere, so it is
impossible for there to be recursion.
We don't call ToggleView programmatically anywhere, so it is
impossible for there to be recursion.
Block signals in ghid_main_menu_update_toggle_state()
The function ghid_main_menu_update_toggle_state() is supposed to
sync the menu checkboxes to the actual state of pcb, by checking
the flags given in the resource file.
If this function is emitting signals and changing pcb's state,
this is a bug. Fortunately, this appears not to be the case, so
the effect of this commit is to eliminate one more use of
ghidgui->toggle_holdoff.
The function ghid_main_menu_update_toggle_state() is supposed to
sync the menu checkboxes to the actual state of pcb, by checking
the flags given in the resource file.
If this function is emitting signals and changing pcb's state,
this is a bug. Fortunately, this appears not to be the case, so
the effect of this commit is to eliminate one more use of
ghidgui->toggle_holdoff.
gtk: sync visiibility of layer selector with core state in LayersChanged
Use signal blocking for visibility toggling in GHidLayerSelector
Add call to ghid_layer_buttons_color_update() when loading new colors
Change change.c to treat text scale as mils
Configure layer selector to only accept left-clicks
Suggested by Kai-Martin Knaak, seconded by me.
Suggested by Kai-Martin Knaak, seconded by me.
Fix invalid free of ~/.pcb/filename path in gui-top-window.c
minor: fix comment and forward declaration in ghid-layer-selector
Remove default layer selection from ghid-layer-selector.c
Having the layer selector select its own first layer is not
needed - pcb does this for us, after making the widget. It's
not the sort of decision a widget should be making on its own,
anyway.
Having the layer selector select its own first layer is not
needed - pcb does this for us, after making the widget. It's
not the sort of decision a widget should be making on its own,
anyway.
Use g_signal_handler_block instead of flags in ghid-layer-selector.c
Thanks to Peter C. for this code-cleanliness tip. Now the two
layer-selection interfaces (menu button and selector widget)
set each other's GUI state but do not raise any signals past
the original.
Thanks to Peter C. for this code-cleanliness tip. Now the two
layer-selection interfaces (menu button and selector widget)
set each other's GUI state but do not raise any signals past
the original.
Add missing free_ldata() in ghid-layer-selector.c
Disable layer selector's GtkAccelGroup while in command mode
draw.c: Add const qualifiers to some BoxType *drawn_area parameters
misc.c: Add const qualifier to BoxType * parameter passed to CountHoles
draw.c: Fold DrawLayerCommon() into DrawLayer()
Since the last commit, DrawLayer() just calls DrawLayerCommon with the
"clear_pins" argument set to true. The only other DrawLayerCommon caller
passes clear_pins as true, so having functions is redundant.
Since the last commit, DrawLayer() just calls DrawLayerCommon with the
"clear_pins" argument set to true. The only other DrawLayerCommon caller
passes clear_pins as true, so having functions is redundant.
DrawLayer(): Pass true to clear_pins of DrawLayerCommon
This should not affect any rendering. If the check planes flag is set,
we should only draw polygons, nothing more. Only a handful of cases draw
layers via this code-path, and in all but the exporter cases, they are
not called if CHECKPLANES is set.
The exporters which call DrawLayer explicitly clear the CHECKPLANES flag
(since commit 3c01bd38cb59922692408b71cd5d77892dbe6ade), so nothing
should be affected by this argument change.
This should not affect any rendering. If the check planes flag is set,
we should only draw polygons, nothing more. Only a handful of cases draw
layers via this code-path, and in all but the exporter cases, they are
not called if CHECKPLANES is set.
The exporters which call DrawLayer explicitly clear the CHECKPLANES flag
(since commit 3c01bd38cb59922692408b71cd5d77892dbe6ade), so nothing
should be affected by this argument change.
hid/{ps,eps,gerber}: Clear CHECKPLANESFLAG before exporting
Ensure we are in a sensible view state before exporting. This
update those HIDs which cleared other similar renedering flags
before exporting to include the CHECKPLANES flag.
Ensure we are in a sensible view state before exporting. This
update those HIDs which cleared other similar renedering flags
before exporting to include the CHECKPLANES flag.
draw.c: Have DrawLayerGroup() call DrawPPV for non-gui exporters
This means DrawLayerGroup() can have a void return type as most of
the other drawing functions, and makes things a little neater.
Only the GUI renderers special case the pin / pad / via to wait
until a later rendering oass than the layers they reside on.
This means DrawLayerGroup() can have a void return type as most of
the other drawing functions, and makes things a little neater.
Only the GUI renderers special case the pin / pad / via to wait
until a later rendering oass than the layers they reside on.
hid/gtk: Remove unused "button" parameter from Popup function.
Remove the dead code and comments refering to the fact the function's
second argument indicates a mouse button number.
Remove the dead code and comments refering to the fact the function's
second argument indicates a mouse button number.
Link GHidLayerSelector and GHidMainMenu
Layer visibility-toggle and selection menu items now appear
in the main menu. Accelerators work correctly and are reassigned
on deletion/addition of layers to simulate the old behavior.
Layer visibility-toggle and selection menu items now appear
in the main menu. Accelerators work correctly and are reassigned
on deletion/addition of layers to simulate the old behavior.
Clean up layer data handling in ghid-layer-selector.c
Give GHidLayerSelector an internal layer structure
Before we had various arrays to resize and index; now each
row has a structure associated with it, that is easier to
access and maintain.
Before we had various arrays to resize and index; now each
row has a structure associated with it, that is easier to
access and maintain.
Replace gtk UI manager with GHidMainMenu widget
This commit replaces the old UI manager with a customize gtk
widget that builds menus directly from a resource tree. This
eliminates the translate-to-XML step, the ugly hacks used to
access individual actions, and all the associated manual
memory management.
This will also give us the ability to have more dynamic menus,
in particular layer lists without maximum capacities.
Layers and route styles are still not hooked into the menu.
This means that those accelerators DO NOT WORK. (This will
be fixed in a later commit.) Checkboxes have been replaced
with radio buttons where appropriate. There are now tearoffs
on the context-menu's submenus.
Other than that, there should be no user-visible changes. ;)
This commit replaces the old UI manager with a customize gtk
widget that builds menus directly from a resource tree. This
eliminates the translate-to-XML step, the ugly hacks used to
access individual actions, and all the associated manual
memory management.
This will also give us the ability to have more dynamic menus,
in particular layer lists without maximum capacities.
Layers and route styles are still not hooked into the menu.
This means that those accelerators DO NOT WORK. (This will
be fixed in a later commit.) Checkboxes have been replaced
with radio buttons where appropriate. There are now tearoffs
on the context-menu's submenus.
Other than that, there should be no user-visible changes. ;)
Created ghid-main-menu.[ch]
Still need to hook up layer selector and route styles.
Still need to hook up layer selector and route styles.
Fix select-hidden-layer behavior
When you select a hidden layer, it should toggle the visibility
so that the currently-selected layer is always visible. We were
toggling twice.
When you select a hidden layer, it should toggle the visibility
so that the currently-selected layer is always visible. We were
toggling twice.
Prevent recursion in layer selector events
Rename GtkPcbCoordEntry to GHidCoordEntry
Rename GtkPcbLayerSelector to GHidLayerSelector
Rename GtkPcbCellRendererVisibility to GHidCellRendererVisibility
Add mnemonics to menus in default gpcb-menu.res.in
You can now access the main menu without a mouse, by doing
Alt+F, for example, to select the File menu.
You can now access the main menu without a mouse, by doing
Alt+F, for example, to select the File menu.
gtk: Const-correct add_resource_to_menu and related functions
Five files have had const keywords added:
../common/hid_resource.c
../common/hid_resource.h
gui-top-window.c
../../res_parse.y
../../resource.h
No casts were added. No compilation warnings were added.
Five files have had const keywords added:
../common/hid_resource.c
../common/hid_resource.h
gui-top-window.c
../../res_parse.y
../../resource.h
No casts were added. No compilation warnings were added.
Delete GtkAction along with layer in gtk-pcb-layer-selector.c
hid/ps/eps.c: Remove assigned by unused lastgroup variable
HID-gcode: make use of MAXPATHLEN.
Affects-bug: lp-699497
Affects-bug: lp-699497
Add attributes to docu for commandline options
Docu: Fix some references to command-line options
and remove the documentation for a non-working X11-Interface option.
and remove the documentation for a non-working X11-Interface option.
Better handling of unplated vias
The attached patch adds checks in the geometry intersection functions to
no longer treat unplated vias (mounting holes) as conducting. The
implementation in the patch will act as if the unplated via doesn't
intersect with metal objects at all, which is possibly not what is
desired. Should the conductivity check happen on a higher level from the
geometry intersection routines? A case that would require this is not
obvious to me.
Closes-bug: lp-699499
The attached patch adds checks in the geometry intersection functions to
no longer treat unplated vias (mounting holes) as conducting. The
implementation in the patch will act as if the unplated via doesn't
intersect with metal objects at all, which is possibly not what is
desired. Should the conductivity check happen on a higher level from the
geometry intersection routines? A case that would require this is not
obvious to me.
Closes-bug: lp-699499
Unify HID description (no fullstop at end of description)
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for ps HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for eps HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for png HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for nemla HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for lpt HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for Gerber HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for the BOM HID commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for commandline-options for GTK+ and lesstif GUI
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for DRC commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for general gui commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for path commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for commandline commands
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for layer names commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for size commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Add docu for color commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Docu: Add general description for commandline options
... and for general options.
(Patch 3/19 of this patch-serie is missing on purpose)
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
... and for general options.
(Patch 3/19 of this patch-serie is missing on purpose)
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Remove out-dated docu for commandline options
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Most parts of this patch-serie was written by Kai-Martin Knaak.
Adaption to actual git HEAD and some modifications by Felix Ruoff.
Move CountHoles() from draw.c to misc.c and export it
This function may be more generally useful.
This function may be more generally useful.
draw.c: Move doing_assy flag assignment into PrintAssembly()
Keeps things tidier
Keeps things tidier
hid/{nelma,gcode}: Remove assigned but unused variables lastcap and lastgroup
Remove traces of LoadBackgroundImage() from the core of PCB
hid/gtk: Use view_data struct to simplify saving and restoring views
hid/gtk: Encapsulate view parameters in a structure
hid/gtk: Remove unnecessary prototype
hid/gtk: crosshair_{x,y} should be Coord, not int.
fontmode.c: Add missing #include "pcb-printf.h"
Fix FontEdit()
Move top/bottom meta-layers to layers 0 and 1 so they'll exist after we
trim out the layers. Set up DRC values to avoid interfereing with the
font layout.
Closes-bug: lp-808591
Move top/bottom meta-layers to layers 0 and 1 so they'll exist after we
trim out the layers. Set up DRC values to avoid interfereing with the
font layout.
Closes-bug: lp-808591
Use correct units when setting up the Sizes dialog.
Replace %mm with %mS so it auto-selects units, to match the scanning
that's done when you save the settings.
Replace %mm with %mS so it auto-selects units, to match the scanning
that's done when you save the settings.
Avoid segfault tmp-saving partial board.
Check for both PCB and PCB->Data to avoid trying to save a backup copy
of a partially created layout.
Check for both PCB and PCB->Data to avoid trying to save a backup copy
of a partially created layout.
gtk: Sync selection with pcb state in ghid_layer_buttons_update
It was possible for PCB's active layer to come out of sync with
the selected entry in the layer selector. This fixes that.
It was possible for PCB's active layer to come out of sync with
the selected entry in the layer selector. This fixes that.