| commit | acbf10c2bf1814c5ffbe13dbcfd03fc9ffcaca89 | |
| author | Peter Clifton <pcjc2@cam.ac.uk> | |
| Thu, 1 Sep 2011 00:56:58 +0000 (1 01:56 +0100) | ||
| committer | Peter Clifton <pcjc2@cam.ac.uk> | |
| Thu, 1 Sep 2011 00:57:09 +0000 (1 01:57 +0100) | ||
| tree | 1b6ee2c1efe960c6ebbf6f994157857290279ddb | treesnapshot (tar.gz zip) |
| parent | 067143f2d8f7e2f7f90bed5d24801332d8cc08f3 | commitdiff |
hid/gtk: Attempt to fix logic to flip component / solder group visibility on flip
Should get back to better behaviour. I probably broke this somewhat with
commit f903b4be6b85efc110852f7be40edf8245f0a513, which attempted to
re-state the previous logic in a clearer fashon.
The logic now should:
If flipping sides, and only ONE of the solder / component layers (groups)
is visible, and that layer (group) is _active_, then swap the visibilities
of the component / solder layers (groups), and make the newly visible
layer (group) active.
There are still bugs in this code relating to the assumption that the
first entry in the layer group is the one which is being toggled. This
breaks if the first entry in the group is that corresponding to the silk
for that side of the board.
Should get back to better behaviour. I probably broke this somewhat with
commit f903b4be6b85efc110852f7be40edf8245f0a513, which attempted to
re-state the previous logic in a clearer fashon.
The logic now should:
If flipping sides, and only ONE of the solder / component layers (groups)
is visible, and that layer (group) is _active_, then swap the visibilities
of the component / solder layers (groups), and make the newly visible
layer (group) active.
There are still bugs in this code relating to the assumption that the
first entry in the layer group is the one which is being toggled. This
breaks if the first entry in the group is that corresponding to the silk
for that side of the board.
| src/hid/gtk/gtkhid-main.c | diffblobblamehistory |