| commit | 77785825fc7fe8a69401dd5d8f856b4425a6b0f2 | |
| author | Peter Clifton <pcjc2@cam.ac.uk> | |
| Fri, 23 Dec 2011 21:37:37 +0000 (23 21:37 +0000) | ||
| committer | Peter Clifton <pcjc2@cam.ac.uk> | |
| Fri, 23 Dec 2011 21:37:37 +0000 (23 21:37 +0000) | ||
| tree | 1d8617026dd8983e62db33cfaa8dfb1abc313975 | treesnapshot (tar.gz zip) |
| parent | c7bc8afec69a3b534714fbe360deaef4e8819215 | commitdiff |
hid/common/hidgl.c: Simplify angle calculation for drawing line caps
Make use of atan2 to avoid special casing horizontal lines, and move
make the input variables doubles to be consistent with that function.
Our use of "tanl" was inappropriate for the float input, dobule output
variables we were using before (spotted by Dan McMahill).
I have modified the semantic meaning of angle, to keep the more
conventional angle = atan2 (dy, dx); geometry. This means the angle
now refers to the angle of the line, not the angle of the line-cap
start. (The angle is adjusted before passing into the cap drawing
routines).
Make use of atan2 to avoid special casing horizontal lines, and move
make the input variables doubles to be consistent with that function.
Our use of "tanl" was inappropriate for the float input, dobule output
variables we were using before (spotted by Dan McMahill).
I have modified the semantic meaning of angle, to keep the more
conventional angle = atan2 (dy, dx); geometry. This means the angle
now refers to the angle of the line, not the angle of the line-cap
start. (The angle is adjusted before passing into the cap drawing
routines).
| src/hid/common/hidgl.c | diffblobblamehistory |