| commit | 0229ff27f664770162a00b9114e4a044153bd537 | |
| author | Peter Clifton <peter@clifton-electronics.co.uk> | |
| Thu, 3 Jan 2013 19:57:47 +0000 (3 19:57 +0000) | ||
| committer | Peter Clifton <peter@clifton-electronics.co.uk> | |
| Thu, 3 Jan 2013 19:57:47 +0000 (3 19:57 +0000) | ||
| tree | b857c6917ad1e7f3e08d704b2880a2a697545152 | treesnapshot (tar.gz zip) |
| parent | 8aa8ec127122ef9dba905a6151d2fd6a29d49e10 | commitdiff |
find.c: Remove some "flag" variable usage in DRCFind()
Avoid confusion by passing *FLAG constants directly to some functions.
This removes several cases where we would set the variable, use it once,
then change it for the next usage, making the code more succinct.
I was not able to remove the flag variable entirely, as the while loop
calling DoIt() relies on it being changed inside the loop in order to
terminate. It should be possible to re-write the loop exit condition if
desired, but I'm not sure I completely understand the behaviour of the
existing code yet.
Avoid confusion by passing *FLAG constants directly to some functions.
This removes several cases where we would set the variable, use it once,
then change it for the next usage, making the code more succinct.
I was not able to remove the flag variable entirely, as the while loop
calling DoIt() relies on it being changed inside the loop in order to
terminate. It should be possible to re-write the loop exit condition if
desired, but I'm not sure I completely understand the behaviour of the
existing code yet.
| src/find.c | diffblobblamehistory |