Peter Clifton [Thu, 8 Nov 2007 00:47:12 +0000 (8 00:47 +0000)]
Ideas in progress for scheme definitions
Peter Clifton [Thu, 8 Nov 2007 00:47:11 +0000 (8 00:47 +0000)]
Add "..." entry button to attribute editor
Peter Clifton [Tue, 6 Nov 2007 23:11:41 +0000 (6 23:11 +0000)]
Free gdk events obtained with gtk_event_get().
gtk_event_put() copies an event given to it, so if we retrieve an event
and re-push it into the event queue, we still need to free our copy.
Peter Clifton [Tue, 6 Nov 2007 23:11:39 +0000 (6 23:11 +0000)]
Refactor XOR drawing functions to avoid code duplication.
Peter Clifton [Tue, 6 Nov 2007 23:09:38 +0000 (6 23:09 +0000)]
Remove full screen redraw calls the rubberbanding and ..._end() functions.
These calls aren't hit, as they were conditional on the inside_action flag
being 0, which should not be the case when these functions are called.
Temporarily add g_assert() statments to verify inside_action != 0 to prove
these changes are appropriate. Assertions should be removed after testing.
Peter Clifton [Fri, 2 Nov 2007 18:27:56 +0000 (2 18:27 +0000)]
Remove the o_redraw_all_fast() function, as its not any faster now.
Historically, o_redraw_all_fast() may have been used for faster drawing
in some cases, however the o_redraw_all() call is now equivelant, with
the addition of redrawing any "place" trails should gschem be mid-action.
Peter Clifton [Thu, 4 Oct 2007 20:24:15 +0000 (4 21:24 +0100)]
Alter system-gafrc to process .scm files in $GEDA_DATA_DIR/gafrc.d/
This change allows each symbol package (e.g. geda-symbols) to install a
scheme config file under this dir to load its contents. This allows
additional symbol packages to be installed globally without needing to edit
either geda-clib.scm or system-gafrc.
Also moves the installation of geda-clib.scm into this directory.
Peter Clifton [Wed, 17 Oct 2007 03:50:39 +0000 (17 04:50 +0100)]
Remove the ATTRIB linked list in favour of a GList
The ATTRIB.copied_to pointer is moved from the ATTRIB struct to reside in
the source OBJECT being copied.
The ATTRIB *attached_to pointer of an attribute's text OBJECT is changed
to OBJECT *attached_to, pointing directly at the OBJECT to which that
attribute is attached. This avoids the need to traverse the ATTRIB list
and retrieve this pointer from the HEAD attribute node. (A HEAD node is
not used in the GList of ATTRIBs).
The ATTRIB structure now only contains one element, OBJECT *object. This
points to the text OBJECT holding and displaying that attribute's
"name=value".
Peter Clifton [Wed, 17 Oct 2007 03:14:38 +0000 (17 04:14 +0100)]
Tidy the o_drawbounding() function to make it more readable.
Peter Clifton [Wed, 17 Oct 2007 03:14:25 +0000 (17 04:14 +0100)]
Add function o_erase_list() to gschem, to undraw a GList of OBJECTS.
Peter Clifton [Wed, 17 Oct 2007 02:53:38 +0000 (17 03:53 +0100)]
Remove unused code from libgeda
Werner Hoch [Tue, 16 Oct 2007 17:38:25 +0000 (16 19:38 +0200)]
Misc corrections for tragesym spacer support
remove spacers if the pinlabels are sorted
don't add pinseq at spacers
modified example to use the spacer support
Werner Hoch [Tue, 16 Oct 2007 16:58:43 +0000 (16 18:58 +0200)]
Added spacer feature to tragesym
A spacer line will put a gap between two pins.
Patch written by Gilbert Forkel. Thanks
Peter Clifton [Tue, 9 Oct 2007 21:28:54 +0000 (9 22:28 +0100)]
Tidy implementation of o_list_copy_all() to be more concise.
Peter Clifton [Tue, 9 Oct 2007 21:27:02 +0000 (9 22:27 +0100)]
Tidy o_redraw() to be more concise and have a tighter inner loop.
Peter Clifton [Tue, 9 Oct 2007 21:05:22 +0000 (9 22:05 +0100)]
Avoid use of global_window_current in gschem/src/x_dialog.c: color_set()
Peter Clifton [Tue, 9 Oct 2007 21:05:21 +0000 (9 22:05 +0100)]
Split out gschem specific TOPLEVEL variables into a new GSCHEM_TOPLEVEL
GSCHEM_TOPLEVEL has a TOPLEVEL *toplevel pointer as its first elelment,
gschem uses this to call libgeda functions. (Almost) all gschem functions
now take the GSCHEM_TOPLEVEL as their first argument.
Peter Clifton [Tue, 9 Oct 2007 19:08:26 +0000 (9 20:08 +0100)]
Move o_redraw_single() from libgeda to gschem
Peter Clifton [Tue, 9 Oct 2007 19:08:26 +0000 (9 20:08 +0100)]
Move libgeda's o_selection_unselect_list() into gschem.
The function calls o_redraw_single(), so should be in gschem.
It is now named o_select_unselect_list().
Peter Clifton [Tue, 9 Oct 2007 19:08:23 +0000 (9 20:08 +0100)]
Fix a bug in o_attrib_search_name_single() were it might return NULL.
If o_attrib_search_name_single() doesn't find an attribute attached to
the passed OBJECT, it checks if the passed OBJECT is itsself an attribute.
In this case, it would return NULL (the result from the preceeding search).
The bug might not actually be triggered in normal usage, as most callers
don't pass a variable to recieve the OBJECT pointer.
Peter Clifton [Thu, 4 Oct 2007 18:42:01 +0000 (4 19:42 +0100)]
Remove OBJECT* linked list argument to o_drawbounding().
All code is now passing GLists of objects to this function.
Peter Clifton [Thu, 4 Oct 2007 18:42:01 +0000 (4 19:42 +0100)]
Use GLists to store OBJECTs in the "object_buffers[]" paste buffers.
Replaces o_list_copy_all_selection2() with o_glist_copy_all_to_glist().
Peter Clifton [Thu, 4 Oct 2007 18:42:00 +0000 (4 19:42 +0100)]
Make attribute / text placing use a new attrib_place_list GList.
Hamish Moffatt [Thu, 4 Oct 2007 18:40:05 +0000 (4 19:40 +0100)]
Fix install location of gattrib-menus.xml to $GEDADATADIR
Peter Clifton [Thu, 4 Oct 2007 01:44:18 +0000 (4 02:44 +0100)]
Remove the redundant toplevel variables current_{show,visible}.
These variables were previously used for an interactive method of attrib
placement which has since been removed. The current_visible variable was
also tested during non-attribute text placement, but to no effect.
Whilst the file-format does technically allow invisible text, gschem's UI
pesesnts no way to achieve it, so removing this variable does no harm. The
ability to correctly load schematics with invisible text remains.
Peter Clifton [Thu, 4 Oct 2007 01:36:19 +0000 (4 02:36 +0100)]
Remove the unused states for attrib placement: DRAWATTRIB and ENDATTRIB.
Also removes the functions:
o_attrib_{start|end|rubberattrib} which are no longer used after this.
Peter Clifton [Thu, 4 Oct 2007 01:35:53 +0000 (4 02:35 +0100)]
Remove the unused function o_erasebounding().
Peter Clifton [Thu, 4 Oct 2007 01:34:50 +0000 (4 02:34 +0100)]
Avoid accessing (GList)->{next|priv} directly to aid debugging.
Instead use g_list_{next|previous}, allowing us to catch errors where
changing from gEDA structures which had their own next and prev pointers.
To debug, edit the glist.h include file from glib, renaming the next and
prev elements in the GList structure and macros. Recompile gEDA to see any
bad accesses such as those where the HEAD nodes were previously skipped.
Werner Hoch [Sat, 15 Sep 2007 08:45:44 +0000 (15 10:45 +0200)]
fixed symbols/linear/lm7912-1.sym
changed pinnumbers and added footprint and some attributes
bumped symversion to 1.0
Michele Petrecca [Wed, 12 Sep 2007 02:49:03 +0000 (11 22:49 -0400)]
Updated Italian translation.
Ales Hvezda [Wed, 12 Sep 2007 02:37:55 +0000 (11 22:37 -0400)]
Fixed a whole bunch of gtk+ 2.4.x and misc issues building on an older box
This is a fix for (Patch#)
1789290 libgeda-1.2.0 fprintf which supplied a
similar patch which fixes the issues in libgeda/src/s_clib.c and
libgeda/src/s_textbuffer.c. In the future, all releases will be built with
gtk+ 2.4.x so that these sorts of problems do not get released.
Peter Clifton [Sun, 9 Sep 2007 13:14:44 +0000 (9 14:14 +0100)]
Avoid un-necessary usage of global_window_current in g_keys_execute()
Peter Clifton [Sun, 9 Sep 2007 13:14:42 +0000 (9 14:14 +0100)]
Avoid use of global_window_current in gschem/src/x_compselect.c
Peter Clifton [Sun, 9 Sep 2007 13:04:21 +0000 (9 14:04 +0100)]
Use a GObject constructor, not instance_init for compselect the dialog.
Using a GObject constructor allows access to the construct time properties
of the object during initialisation, whereas at execution of the GType
instance_init function, those properties have not been set.
Peter Clifton [Sun, 9 Sep 2007 11:51:00 +0000 (9 12:51 +0100)]
Remove unused TOPLEVEL variables display_{width,height}
Peter Clifton [Sat, 8 Sep 2007 23:54:12 +0000 (9 00:54 +0100)]
Fix grid snapping in "Edit->Mirror Mode"
Where the user selectes Edit->Mirror Mode, then clicks a point about which
to mirror, the snap operation on the mouse coordinates was not taking place
until after the mirror. Bug was introduced with noscreen changes.
Peter Clifton [Sat, 8 Sep 2007 23:18:34 +0000 (9 00:18 +0100)]
Remove the globally exported variable_set_func.
Only gattrib provided a non-NULL export of this symbol, and such imports
into libgeda prevent libgeda being dynamically linked on some platforms.
To better match the other tools in the suite, gattrib's i_vars_set() and
i_window_vars_set() functions were combined into a single i_vars_set().
Peter Clifton [Sat, 8 Sep 2007 23:01:14 +0000 (9 00:01 +0100)]
Remove unused extern variables from libgeda, gnetlist and utils.
Peter Clifton [Sat, 8 Sep 2007 22:26:47 +0000 (8 23:26 +0100)]
Use o_translate_world() to tidy up o_complex_translate_world()
Removed o_complex_world_translate_toplevel(), and changed all useage of
o_complex_translate_world() for generic lists of objects to instead use
the new o_list_translate_world(). o_glist_translate_world() is also added.
Peter Clifton [Sat, 8 Sep 2007 22:24:33 +0000 (8 23:24 +0100)]
Add new function o_translate_world() which will translate any object.
Peter Clifton [Sat, 8 Sep 2007 22:24:27 +0000 (8 23:24 +0100)]
Rename o_complex_world_translate() to o_complex_translate_world()
The function name now matches the pattern for other objects types.
Peter Clifton [Sat, 8 Sep 2007 14:49:02 +0000 (8 15:49 +0100)]
Remove unused function o_attrib_search_special().
Peter Clifton [Sat, 8 Sep 2007 14:26:33 +0000 (8 15:26 +0100)]
Remove unused function o_attrib_count_toplevel().
Peter Clifton [Sat, 8 Sep 2007 14:26:32 +0000 (8 15:26 +0100)]
Remove empty functions o_attrib_{edit,select_draw,unselect_draw}().
Peter Clifton [Sat, 8 Sep 2007 14:26:31 +0000 (8 15:26 +0100)]
Remove unused function o_text_input().
Peter Clifton [Sat, 8 Sep 2007 12:13:38 +0000 (8 13:13 +0100)]
Remove auto-uref code which was #ifdef'd out. its no longer used.
Peter Clifton [Fri, 7 Sep 2007 23:30:49 +0000 (8 00:30 +0100)]
Remove unused OBJECT *object_selected from PAGE structure.
Peter Clifton [Fri, 7 Sep 2007 23:17:05 +0000 (8 00:17 +0100)]
Remove o_complex_translate{2,_selection,_display_selection}()
o_complex_translate{_selection,_display_selection}() were unused,
o_complex_translate2() simply wrapped o_complex_translate_display().
Peter Clifton [Fri, 7 Sep 2007 23:17:03 +0000 (8 00:17 +0100)]
Removed unnecessary angle parameter to o_complex_rotate_world(), fix bug.
Fix rotation code to support angles other than 90 degrees. All current
users actually pass 90 degrees so this bug had no visible effect.
Peter Clifton [Fri, 7 Sep 2007 22:58:51 +0000 (7 23:58 +0100)]
Removed unused angle parameter to o_complex_rotate_lowlevel().
Peter Clifton [Fri, 7 Sep 2007 22:57:38 +0000 (7 23:57 +0100)]
Removed unused angle parameter to o_text_rotate_world().
From an old unmerged patch by Patrick Bernaud.
Peter Clifton [Thu, 6 Sep 2007 23:20:29 +0000 (7 00:20 +0100)]
Avoid use of gtk_cell_renderer_stop_editing(), which is GTK 2.6+
Instead emit the "editing-canceled" signal directly if necessary.
Peter Clifton [Wed, 5 Sep 2007 17:47:23 +0000 (5 18:47 +0100)]
Simplify test to call gdk_init() in o_read_picture()
Avoids testing a GtkWidget pointer in TOPLEVEL variable setup by gschem or
gattrib. Instead, just ensure we call gdk_init() at least once. If gschem
or gattrib already did, its not a problem as repeated calls aren't harmful.
Peter Clifton [Wed, 5 Sep 2007 17:47:23 +0000 (5 18:47 +0100)]
Tidy o_picture_copy(), avoiding use of some TOPLEVEL variables
Peter Clifton [Wed, 5 Sep 2007 17:39:55 +0000 (5 18:39 +0100)]
Fix loading of embedded images.
Various bugs in the base64 decoding function were preventing the correct
decoding of the embedded image. In addition, it was possible for this code
to access invalid memory - possibly leading to a crash.
Additionally removes extra \n inserted between lines of the base64 input.
Peter Clifton [Wed, 5 Sep 2007 13:38:13 +0000 (5 14:38 +0100)]
Remove un-necessary variable re-initialisations in x_window_setup().
The initialisations removed are the same as those in s_toplevel_new().
Peter Clifton [Wed, 5 Sep 2007 13:38:02 +0000 (5 14:38 +0100)]
Remove the un-needed TOPLEVEL variable: DONT_RECALC, and its usage.
Peter Clifton [Wed, 5 Sep 2007 13:37:56 +0000 (5 14:37 +0100)]
Remove the redundant TOPLEVEL variable: DONT_RESIZE
Peter Clifton [Wed, 5 Sep 2007 13:37:49 +0000 (5 14:37 +0100)]
Remove the redundant TOPLEVEL variable: DONT_DRAW_CONN
Peter Clifton [Wed, 5 Sep 2007 13:37:41 +0000 (5 14:37 +0100)]
Remove unused variables from the TOPLEVEL structure
Peter Clifton [Wed, 5 Sep 2007 13:34:11 +0000 (5 14:34 +0100)]
Use o_attrib_print() in libgeda/src/s_basic.c avoiding code duplication.
Printed output will be slightly different, but this is just debug code.
Peter Clifton [Wed, 5 Sep 2007 13:19:25 +0000 (5 14:19 +0100)]
Remove unused function o_attrib_reattach()
Peter Clifton [Wed, 5 Sep 2007 13:19:19 +0000 (5 14:19 +0100)]
Remove unused functions o_attrib_copy() and o_attrib_copy_all().
Peter Clifton [Wed, 5 Sep 2007 13:19:05 +0000 (5 14:19 +0100)]
Remove unused function o_attrib_test_detach()
Peter Clifton [Wed, 5 Sep 2007 13:19:00 +0000 (5 14:19 +0100)]
Remove unused, empty function o_attrib_detach_all()
Peter Clifton [Wed, 5 Sep 2007 13:18:50 +0000 (5 14:18 +0100)]
Remove unused function o_attrib_print_reverse()
Peter Clifton [Wed, 5 Sep 2007 12:46:57 +0000 (5 13:46 +0100)]
Fix memory corruption and possible segfault copying attributes
If an object (but not all its attributes) was selected and copied, dangling
pointers were left in the un-copied attributes. A subsequent copy operation
containing those missed attributes would attempt to reattach them to the
copy of their parent. If this had been deleted in the mean time, memory
corruption and a possible segfault would occur.
Consolidates the duplicated code which sets the ATTRIB property "copied_to"
into a helper function, o_attrib_list_copied_to(). This is also used to
clean up after copy operations.
Peter Clifton [Mon, 3 Sep 2007 15:48:32 +0000 (3 16:48 +0100)]
Move o_picture_set_pixbuf() from libgeda to gschem
Peter Clifton [Mon, 3 Sep 2007 15:48:09 +0000 (3 16:48 +0100)]
Remove unused TOPLEVEL variable REMOVING_SEL.
Peter Clifton [Mon, 3 Sep 2007 15:47:22 +0000 (3 16:47 +0100)]
Remove unused dialog pointers from TOPLEVEL
Peter Clifton [Mon, 3 Sep 2007 15:46:55 +0000 (3 16:46 +0100)]
Remove unneeded functions in libgeda/o_attrib.c
Removes:
o_attrib_set_show(TOPLEVEL *toplevel, int flag)
o_attrib_set_visible(TOPLEVEL *toplevel, int flag)
Peter Clifton [Mon, 3 Sep 2007 15:46:20 +0000 (3 16:46 +0100)]
Remove un-needed redraw in o_scale() and generally tidied the function up
Peter Clifton [Mon, 3 Sep 2007 15:46:09 +0000 (3 16:46 +0100)]
Remove ineffective redraw in o_complex_world_translate()
Peter Clifton [Mon, 3 Sep 2007 15:41:28 +0000 (3 16:41 +0100)]
Removes the linking between TOPLEVELs, instead uses a GList in gschem
Peter Clifton [Mon, 3 Sep 2007 15:38:53 +0000 (3 16:38 +0100)]
libgeda: Rename all w_current variables to toplevel
Peter Clifton [Mon, 3 Sep 2007 14:32:27 +0000 (3 15:32 +0100)]
Remove gattrib's use of GTK widget pointers stored in TOPLEVEL.
Peter Clifton [Mon, 3 Sep 2007 14:32:27 +0000 (3 15:32 +0100)]
Remove gattrib's use of TOPLEVEL rc-variables defined in gschem.
Peter Clifton [Mon, 3 Sep 2007 14:32:27 +0000 (3 15:32 +0100)]
Remove some unused / ineffective code in gattrib.
Peter Clifton [Mon, 3 Sep 2007 14:32:27 +0000 (3 15:32 +0100)]
Make use of o_select_unselect_all() to reduce code duplication in gschem
Peter Clifton [Mon, 3 Sep 2007 14:32:27 +0000 (3 15:32 +0100)]
Remove o_unselect_all() function, instead use o_select_unselect_all()
Peter Clifton [Mon, 3 Sep 2007 14:32:25 +0000 (3 15:32 +0100)]
Remove unused GType instance_init functions in gschem.
Peter Clifton [Mon, 3 Sep 2007 14:28:33 +0000 (3 15:28 +0100)]
Remove unused header file gschem/include/x_event.h
Peter Clifton [Mon, 3 Sep 2007 12:49:51 +0000 (3 13:49 +0100)]
x_compselect.c: Avoid using GValue to set properties where unnecessary
Peter Clifton [Mon, 3 Sep 2007 11:17:25 +0000 (3 12:17 +0100)]
Avoid using s_hierarchy_up() for traversal when we know where we're going.
When trying to reach a specific parent we've come from before, we can use
s_page_goto() and avoid the search through the page list.
Peter Clifton [Mon, 3 Sep 2007 11:17:19 +0000 (3 12:17 +0100)]
Fix indenting / whitespace in gschem/src/o_misc.c
Peter Clifton [Mon, 3 Sep 2007 11:15:43 +0000 (3 12:15 +0100)]
Replace the linked list of PAGEs with a GedaList (typecast to GedaPageList)
Ales Hvezda [Mon, 3 Sep 2007 02:48:59 +0000 (2 22:48 -0400)]
Last minute updates to the READMEs for all projects
Cherry picked from stable-1.2 branch, since these changes apply to master
too.
(cherry picked from commit
88fcb8d1bcdaa1436572d6a0ebe86f4df242a8d6)
Ales Hvezda [Mon, 3 Sep 2007 01:11:05 +0000 (2 21:11 -0400)]
Updated po/pot files by running make update-po
Ales Hvezda [Mon, 3 Sep 2007 00:54:49 +0000 (2 20:54 -0400)]
Fix for Bug#
1782032: Blank attibute name when attribute value starts with " "
In order to fix this bug, we needed to validate the input attribute when:
1) input an attribute using the single attribute editor,
2) Add an attribute in the multi-attribute editor
3) Modify the name or value of an attribute in the multi-attribute editor
An attribute is not valid if the name or value are empty, name ends with a
space, and/or value starts with a space. o_attrib_get_name_value does
this validation throughout gaf.
Ales Hvezda [Sun, 2 Sep 2007 22:52:50 +0000 (2 18:52 -0400)]
Moved refresh button in component select dialog box
The refresh button was along the very bottom of the component select
dialog box at the same level as Close, Apply, and OK. The refresh
operation is not nearly as important or first class as these actions.
The refresh button was moved to the filter area. Whether this change
sticks depends on what users think of the new location (I'm quite willing
to move it elsewhere if there is a better spot).
Ales Hvezda [Sun, 2 Sep 2007 22:21:24 +0000 (2 18:21 -0400)]
Added standard Control-z and Control-y keymappings for Undo and Redo
Ales Hvezda [Sun, 2 Sep 2007 20:50:29 +0000 (2 16:50 -0400)]
Fix for Bug#
1776547: graphical versus source
The usage described in Bug#
1776547 is pretty unique, but it might be handy
to support in general. The recursive source= and graphical= behavior is
a unexpected side effect of the traversal of graphical symbols/components
(
552e06e921e4b6eb758b9483d1913c39b3fef5f5). The fix is to explicitly
check for the graphical= attribute and if it is found to not further
traverse the hierarchy. Regression tests were added so this behavior
doesn't change in the future.
Ales Hvezda [Mon, 20 Aug 2007 03:03:54 +0000 (19 23:03 -0400)]
Another set of po files changed via make distcheck
Ales Hvezda [Mon, 20 Aug 2007 02:40:19 +0000 (19 22:40 -0400)]
Update ChangeLogs using: ./update-changelogs.sh 1.0-
20070526..master
Ales Hvezda [Sat, 18 Aug 2007 20:41:24 +0000 (18 16:41 -0400)]
Added undo-panzoom keyword to control if pan/zoom cmds are undoable
The default is to still store the pan/zoom info when panning or zooming,
but now the user has a choice.
Ales Hvezda [Sat, 18 Aug 2007 20:17:45 +0000 (18 16:17 -0400)]
Toplevel gschem menu tweaks
Added ... to some entries that open up dialog boxes or other windows
Changed the ordering of Hotkeys and About in the Help menu
Removed obsolete comment about the help menu being right justified
Ales Hvezda [Sat, 18 Aug 2007 20:14:30 +0000 (18 16:14 -0400)]
Bumped versions to 1.1.2/
20070818/30:2:0 for the next development snapshot
Ales Hvezda [Sat, 18 Aug 2007 19:46:17 +0000 (18 15:46 -0400)]
Another attempt to commit wiki snapshot updates
Ales Hvezda [Sat, 18 Aug 2007 19:36:44 +0000 (18 15:36 -0400)]
Updated wiki snapshot from the live wiki
Ales Hvezda [Sat, 18 Aug 2007 18:21:53 +0000 (18 14:21 -0400)]
Added dist-license and use-license to the attribute-name keyword