From ce698a5b5e70f1622473b35735e1b7f3c6a3ab88 Mon Sep 17 00:00:00 2001 From: Karl Tomlinson Date: Tue, 27 Jun 2023 00:17:28 +0000 Subject: [PATCH] Bug 1829068 add comments to clarify MediaSink times correspond to MediaData::mTime r=padenot unlike MediaDecoderStateMachine::GetMediaTime(). Depends on D181968 Differential Revision: https://phabricator.services.mozilla.com/D181969 --- dom/media/mediasink/AudioSink.h | 3 ++- dom/media/mediasink/MediaSink.h | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/dom/media/mediasink/AudioSink.h b/dom/media/mediasink/AudioSink.h index 4f160bdbb8a8..4f92a307ddea 100644 --- a/dom/media/mediasink/AudioSink.h +++ b/dom/media/mediasink/AudioSink.h @@ -51,7 +51,8 @@ class AudioSink : private AudioStream::DataSource { const RefPtr& aAudioDevice, InitializationType aInitializationType); - // Start audio playback. + // Start audio playback. aStartTime is compared with MediaData::mTime to + // identify the first audio frame to be played. RefPtr Start(const media::TimeUnit& aStartTime); /* diff --git a/dom/media/mediasink/MediaSink.h b/dom/media/mediasink/MediaSink.h index 41827173ee7d..f6170df72891 100644 --- a/dom/media/mediasink/MediaSink.h +++ b/dom/media/mediasink/MediaSink.h @@ -55,7 +55,7 @@ class MediaSink { // Must be called after playback starts. virtual media::TimeUnit GetEndTime(TrackType aType) const = 0; - // Return playback position of the media. + // Return playback position for the media data. // Since A/V sync is always maintained by this sink, there is no need to // specify whether we want to get audio or video position. // aTimeStamp returns the timeStamp corresponding to the returned position @@ -102,8 +102,10 @@ class MediaSink { // Do nothing if this sink has no video track. Can be called in any state. virtual void Redraw(const VideoInfo& aInfo){}; - // Begin a playback session with the provided start time and media info. - // Must be called when playback is stopped. + // Begin a playback session with the provided start time in the media data + // and media info. Must be called when playback is stopped. aStartTime is + // compared with MediaData::mTime and continues to increase when looping, + // unless decoding is reset. virtual nsresult Start(const media::TimeUnit& aStartTime, const MediaInfo& aInfo) = 0; -- 2.11.4.GIT