From b9ba404e4c34a92d4c9e8fde8182ac82bae1de70 Mon Sep 17 00:00:00 2001 From: Tomislav Jovanovic Date: Thu, 28 Oct 2021 12:11:48 +0000 Subject: [PATCH] Bug 1645565 - Avoid using innerText in test_ext_contentscript_fission_frame r=willdurand innerText can be flaky for unrelated reasons, and we dont't actually need it for this test. Differential Revision: https://phabricator.services.mozilla.com/D129703 --- toolkit/components/extensions/test/mochitest/mochitest-common.ini | 4 ---- .../test/mochitest/test_ext_contentscript_fission_frame.html | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/toolkit/components/extensions/test/mochitest/mochitest-common.ini b/toolkit/components/extensions/test/mochitest/mochitest-common.ini index 8eb6908a200c..013e5cae28c1 100644 --- a/toolkit/components/extensions/test/mochitest/mochitest-common.ini +++ b/toolkit/components/extensions/test/mochitest/mochitest-common.ini @@ -102,10 +102,6 @@ fail-if = xorigin # TypeError: can't access property "staticScripts", ext is und skip-if = (os == 'android') || (verify && debug && (os == 'linux')) # Bug 1617062 [test_ext_contentscript_devtools_metadata.html] [test_ext_contentscript_fission_frame.html] -skip-if = - os == 'mac' && bits == 64 && !debug # Bug 1645565 - os == 'win' && bits == 64 && !debug # Bug 1645565 - win10_2004 # Bug 1645565 [test_ext_contentscript_incognito.html] skip-if = os == 'android' # Android does not support multiple windows. [test_ext_contentscript_permission.html] diff --git a/toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html b/toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html index 58f05de10852..69588f35e364 100644 --- a/toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html +++ b/toolkit/components/extensions/test/mochitest/test_ext_contentscript_fission_frame.html @@ -58,7 +58,7 @@ add_task(async function test_content_script_cross_origin_frame() { files: { "cs.js"() { - let text = document.body.innerText; + let text = document.getElementById("test").textContent; browser.test.assertEq(text, "Sample text", "CS can access page DOM"); let manifest = browser.runtime.getManifest(); -- 2.11.4.GIT