From b5969d7a88737778290191d9ad6c4bf23722a381 Mon Sep 17 00:00:00 2001 From: Arturo Mejia Date: Thu, 20 Apr 2023 15:57:08 -0400 Subject: [PATCH] Bug 1796305 - Remove disable UnusedResource lint We can now remove the UnusedResource lint rule because lint will now pass as expected since the resources are found in the monorepo, which failed prior because the resources were used in different repos. --- .../android-components/components/browser/errorpages/build.gradle | 7 ------- .../android-components/components/feature/addons/build.gradle | 3 --- mobile/android/android-components/components/ui/icons/build.gradle | 5 ----- 3 files changed, 15 deletions(-) diff --git a/mobile/android/android-components/components/browser/errorpages/build.gradle b/mobile/android/android-components/components/browser/errorpages/build.gradle index 51907ef567cf..be6755788a17 100644 --- a/mobile/android/android-components/components/browser/errorpages/build.gradle +++ b/mobile/android/android-components/components/browser/errorpages/build.gradle @@ -15,13 +15,6 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } - lint { - // Lint reports (falsely) a bunch of unused resources for this project. Those resources - // are references from Kotlin code and it looks like Android lint can't see those references - // yet. Let's disable this check and retry once a newer SDK is available. - disable 'UnusedResources' - } - buildTypes { release { minifyEnabled false diff --git a/mobile/android/android-components/components/feature/addons/build.gradle b/mobile/android/android-components/components/feature/addons/build.gradle index 41dc09b00d16..c9ed2968c483 100644 --- a/mobile/android/android-components/components/feature/addons/build.gradle +++ b/mobile/android/android-components/components/feature/addons/build.gradle @@ -38,9 +38,6 @@ android { lint { warningsAsErrors true abortOnError true - - // https://github.com/mozilla-mobile/android-components/issues/10642 - disable 'UnusedResources' } buildFeatures { diff --git a/mobile/android/android-components/components/ui/icons/build.gradle b/mobile/android/android-components/components/ui/icons/build.gradle index 1c91a22b1318..452418875066 100644 --- a/mobile/android/android-components/components/ui/icons/build.gradle +++ b/mobile/android/android-components/components/ui/icons/build.gradle @@ -12,11 +12,6 @@ android { targetSdkVersion config.targetSdkVersion } - lint { - // All icons are unused in this module. - disable 'UnusedResources' - } - buildTypes { release { minifyEnabled false -- 2.11.4.GIT