From b02cbc9c37823463ebce6915f096ba0db69372c5 Mon Sep 17 00:00:00 2001
From: Mirko Brodesser <mbrodesser@igalia.com>
Date: Mon, 7 Aug 2023 11:46:18 +0000
Subject: [PATCH] Bug 1839316: part 2) Implement getting and setting
 "fetchpriority" content attribute of `<script>` element. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D181752
---
 dom/html/FetchPriority.cpp                         | 13 ++++++++++
 dom/html/FetchPriority.h                           | 23 ++++++++++++++++++
 dom/html/HTMLScriptElement.cpp                     | 28 ++++++++++++++++++++++
 dom/html/HTMLScriptElement.h                       |  6 ++---
 dom/html/moz.build                                 |  2 ++
 .../attr-script-fetchpriority.html.ini             |  6 -----
 6 files changed, 68 insertions(+), 10 deletions(-)
 create mode 100644 dom/html/FetchPriority.cpp
 create mode 100644 dom/html/FetchPriority.h
 delete mode 100644 testing/web-platform/meta/html/scripting/the-script-element/attr-script-fetchpriority.html.ini

diff --git a/dom/html/FetchPriority.cpp b/dom/html/FetchPriority.cpp
new file mode 100644
index 000000000000..77a48a2677ca
--- /dev/null
+++ b/dom/html/FetchPriority.cpp
@@ -0,0 +1,13 @@
+/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
+/* vim: set ts=8 sts=2 et sw=2 tw=80: */
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "mozilla/dom/FetchPriority.h"
+
+namespace mozilla::dom {
+const char* kFetchPriorityAttributeValueHigh = "high";
+const char* kFetchPriorityAttributeValueLow = "low";
+const char* kFetchPriorityAttributeValueAuto = "auto";
+}  // namespace mozilla::dom
diff --git a/dom/html/FetchPriority.h b/dom/html/FetchPriority.h
new file mode 100644
index 000000000000..9c71c7997d07
--- /dev/null
+++ b/dom/html/FetchPriority.h
@@ -0,0 +1,23 @@
+/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
+/* vim: set ts=8 sts=2 et sw=2 tw=80: */
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#ifndef mozilla_dom_FetchPriority_h
+#define mozilla_dom_FetchPriority_h
+
+#include <cstdint>
+
+namespace mozilla::dom {
+
+// <https://html.spec.whatwg.org/multipage/urls-and-fetching.html#fetch-priority-attributes>.
+enum class FetchPriority : uint8_t { High, Low, Auto };
+
+extern const char* kFetchPriorityAttributeValueHigh;
+extern const char* kFetchPriorityAttributeValueLow;
+extern const char* kFetchPriorityAttributeValueAuto;
+
+}  // namespace mozilla::dom
+
+#endif  // mozilla_dom_FetchPriority_h
diff --git a/dom/html/HTMLScriptElement.cpp b/dom/html/HTMLScriptElement.cpp
index c5edba752a6e..4f0593fa4f66 100644
--- a/dom/html/HTMLScriptElement.cpp
+++ b/dom/html/HTMLScriptElement.cpp
@@ -4,6 +4,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+#include "nsAttrValue.h"
 #include "nsGkAtoms.h"
 #include "nsStyleConsts.h"
 #include "mozilla/dom/Document.h"
@@ -18,6 +19,7 @@
 #include "nsDOMJSUtils.h"
 #include "nsIScriptError.h"
 #include "nsISupportsImpl.h"
+#include "mozilla/dom/FetchPriority.h"
 #include "mozilla/dom/HTMLScriptElement.h"
 #include "mozilla/dom/HTMLScriptElementBinding.h"
 #include "mozilla/StaticPrefs_dom.h"
@@ -58,6 +60,19 @@ nsresult HTMLScriptElement::BindToTree(BindContext& aContext,
   return NS_OK;
 }
 
+namespace {
+// <https://html.spec.whatwg.org/multipage/urls-and-fetching.html#fetch-priority-attributes>.
+static const nsAttrValue::EnumTable kFetchPriorityEnumTable[] = {
+    {kFetchPriorityAttributeValueHigh, FetchPriority::High},
+    {kFetchPriorityAttributeValueLow, FetchPriority::Low},
+    {kFetchPriorityAttributeValueAuto, FetchPriority::Auto},
+    {nullptr, 0}};
+
+// <https://html.spec.whatwg.org/multipage/urls-and-fetching.html#fetch-priority-attributes>.
+static const nsAttrValue::EnumTable*
+    kFetchPriorityEnumTableInvalidValueDefault = &kFetchPriorityEnumTable[2];
+}  // namespace
+
 bool HTMLScriptElement::ParseAttribute(int32_t aNamespaceID, nsAtom* aAttribute,
                                        const nsAString& aValue,
                                        nsIPrincipal* aMaybeScriptedPrincipal,
@@ -72,6 +87,13 @@ bool HTMLScriptElement::ParseAttribute(int32_t aNamespaceID, nsAtom* aAttribute,
       aResult.ParseStringOrAtom(aValue);
       return true;
     }
+
+    if (aAttribute == nsGkAtoms::fetchpriority) {
+      aResult.ParseEnumValue(aValue, kFetchPriorityEnumTable,
+                             false /* aCaseSensitive */,
+                             kFetchPriorityEnumTableInvalidValueDefault);
+      return true;
+    }
   }
 
   return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
@@ -211,6 +233,12 @@ bool HTMLScriptElement::HasScriptContent() {
          nsContentUtils::HasNonEmptyTextContent(this);
 }
 
+void HTMLScriptElement::GetFetchPriority(nsAString& aFetchPriority) const {
+  // <https://html.spec.whatwg.org/multipage/urls-and-fetching.html#fetch-priority-attributes>.
+  GetEnumAttr(nsGkAtoms::fetchpriority, kFetchPriorityAttributeValueAuto,
+              aFetchPriority);
+}
+
 // https://html.spec.whatwg.org/multipage/scripting.html#dom-script-supports
 /* static */
 bool HTMLScriptElement::Supports(const GlobalObject& aGlobal,
diff --git a/dom/html/HTMLScriptElement.h b/dom/html/HTMLScriptElement.h
index 8c6984468b25..9397a1f323f2 100644
--- a/dom/html/HTMLScriptElement.h
+++ b/dom/html/HTMLScriptElement.h
@@ -128,12 +128,10 @@ class HTMLScriptElement final : public nsGenericHTMLElement,
     GetEnumAttr(nsGkAtoms::referrerpolicy, "", aReferrerPolicy);
   }
 
-  void GetFetchPriority(nsAString& aFetchPriority) {
-    // TODO: impl.
-  }
+  void GetFetchPriority(nsAString& aFetchPriority) const;
 
   void SetFetchPriority(const nsAString& aFetchPriority) {
-    // TODO: impl.
+    SetHTMLAttr(nsGkAtoms::fetchpriority, aFetchPriority);
   }
 
   [[nodiscard]] static bool Supports(const GlobalObject& aGlobal,
diff --git a/dom/html/moz.build b/dom/html/moz.build
index 1dc679dce381..bb87e0f068b2 100644
--- a/dom/html/moz.build
+++ b/dom/html/moz.build
@@ -43,6 +43,7 @@ EXPORTS.mozilla += [
 EXPORTS.mozilla.dom += [
     "ConstraintValidation.h",
     "ElementInternals.h",
+    "FetchPriority.h",
     "HTMLAllCollection.h",
     "HTMLAnchorElement.h",
     "HTMLAreaElement.h",
@@ -127,6 +128,7 @@ EXPORTS.mozilla.dom += [
 UNIFIED_SOURCES += [
     "ConstraintValidation.cpp",
     "ElementInternals.cpp",
+    "FetchPriority.cpp",
     "HTMLAllCollection.cpp",
     "HTMLAnchorElement.cpp",
     "HTMLAreaElement.cpp",
diff --git a/testing/web-platform/meta/html/scripting/the-script-element/attr-script-fetchpriority.html.ini b/testing/web-platform/meta/html/scripting/the-script-element/attr-script-fetchpriority.html.ini
deleted file mode 100644
index 08ed7410bf7f..000000000000
--- a/testing/web-platform/meta/html/scripting/the-script-element/attr-script-fetchpriority.html.ini
+++ /dev/null
@@ -1,6 +0,0 @@
-[attr-script-fetchpriority.html]
-  [fetchpriority attribute on <script> elements should reflect valid IDL values]
-    expected: FAIL
-
-  [default fetchpriority attribute on <script> elements should be 'auto']
-    expected: FAIL
-- 
2.11.4.GIT