From ae9a4a8a00e6a924b56d94a3891f93db645ee21a Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Fri, 22 Oct 2021 17:20:10 -0700 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 - post: switch generic marker skip to BaseBrowserFragment. Since we instrument the marker with the duration in BaseBrowserFragment, we should skip on BaseBrowserFragment too, not its subclass, BrowserFragment. --- .../java/org/mozilla/fenix/perf/MarkersFragmentLifecycleCallbacks.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/MarkersFragmentLifecycleCallbacks.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/MarkersFragmentLifecycleCallbacks.kt index 9d5828f89709..33f2b3d65f60 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/MarkersFragmentLifecycleCallbacks.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/MarkersFragmentLifecycleCallbacks.kt @@ -11,7 +11,7 @@ import androidx.fragment.app.Fragment import androidx.fragment.app.FragmentManager import kotlinx.coroutines.ExperimentalCoroutinesApi import mozilla.components.concept.engine.Engine -import org.mozilla.fenix.browser.BrowserFragment +import org.mozilla.fenix.browser.BaseBrowserFragment import org.mozilla.fenix.home.HomeFragment /** @@ -85,7 +85,7 @@ class MarkersFragmentLifecycleCallbacks( if (shouldSkip() || // These methods are manually instrumented with duration. f is HomeFragment || - f is BrowserFragment // instrumented in BaseBrowserFragment. + f is BaseBrowserFragment ) { return } -- 2.11.4.GIT