From 9856e719998bdcb9fc2fae3b6d4f4986af8b6f23 Mon Sep 17 00:00:00 2001 From: Austin Sullivan Date: Thu, 9 Jun 2022 16:18:17 +0000 Subject: [PATCH] Bug 1771540 [wpt PR 34240] - FSA: EnforceRange on FileSystemReadWriteOptions.at, a=testonly Automatic update from web-platform-tests FSA: EnforceRange on FileSystemReadWriteOptions.at Passing an invalid read or write offset should throw a TypeError This was pointed out in https://github.com/whatwg/fs/issues/31 Bug: 1327741 Change-Id: Icd22cfefa49900a3f2e50c9baaeb766a2f1134fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3671807 Reviewed-by: Daniel Cheng Commit-Queue: Austin Sullivan Cr-Commit-Position: refs/heads/main@{#1010629} -- wpt-commits: 1e43eadaa121e0577b8a78f97d608687ed160351 wpt-pr: 34240 --- ...temSyncAccessHandle-read-write.https.tentative.worker.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/testing/web-platform/tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js b/testing/web-platform/tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js index eb93c0681b26..9f2a61db78e6 100644 --- a/testing/web-platform/tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js +++ b/testing/web-platform/tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js @@ -182,8 +182,17 @@ sync_access_handle_test((t, handle) => { sync_access_handle_test((t, handle) => { const readBuffer = new Uint8Array(24); - assert_throws_dom( - 'NotSupportedError', () => handle.read(readBuffer, { at: -1 })); + assert_throws_js(TypeError, () => handle.read(readBuffer, {at: -1})); }, 'Test reading at a negative offset fails.'); +sync_access_handle_test((t, handle) => { + const text = 'foobar'; + const writeBuffer = new TextEncoder().encode(text); + assert_throws_js(TypeError, () => handle.write(writeBuffer, {at: -1})); + + const readBuffer = new Uint8Array(24); + const readBytes = handle.read(readBuffer, {at: 0}); + assert_equals(0, readBytes, 'Check that no bytes were written'); +}, 'Test writing at a negative offset fails.'); + done(); -- 2.11.4.GIT