From 9578a673c294d55bf7230a10b5e9d3cba5e25313 Mon Sep 17 00:00:00 2001 From: Severin Rudie Date: Tue, 7 Jan 2020 10:47:33 -0800 Subject: [PATCH] [fenix] For 6832: update implementation/comment to align w existing AC code --- .../fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index 7c89046e9da4..5d30f6b6dfa9 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -230,7 +230,9 @@ class HomeFragment : Fragment() { setupHomeMenu() viewLifecycleOwner.lifecycleScope.launch(IO) { - // This should be unnecessary, but we've seen crashes around it. See #6832 + // This is necessary due to a bug in viewLifecycleOwner. See: + // https://github.com/mozilla-mobile/android-components/blob/master/components/lib/state/src/main/java/mozilla/components/lib/state/ext/Fragment.kt#L32-L56 + // TODO remove when viewLifecycleOwner is fixed val context = context ?: return@launch val iconSize = resources.getDimensionPixelSize(R.dimen.preference_icon_drawable_size) -- 2.11.4.GIT