From 650962b2224072518155067d84b84838ac373a3a Mon Sep 17 00:00:00 2001
From: Arturo Mejia <arturomejiamarmol@gmail.com>
Date: Mon, 12 Dec 2022 10:08:02 -0500
Subject: [PATCH] [fenix] No issue: Update Cookie banner handling strings

---
 .../protections/cookiebanners/CookieBannerHandlingDetailsView.kt      | 3 ++-
 mobile/android/fenix/app/src/main/res/values/strings.xml              | 4 ++--
 .../protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt  | 3 +++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsView.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsView.kt
index c73c777ecbd1..305d27c5af12 100644
--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsView.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsView.kt
@@ -63,7 +63,8 @@ class CookieBannerHandlingDetailsView(
             } else {
                 R.string.reduce_cookie_banner_details_panel_description_on_for_site
             }
-        binding.details.text = context.getString(stringID, context.getString(R.string.app_name))
+        val appName = context.getString(R.string.app_name)
+        binding.details.text = context.getString(stringID, appName, appName)
     }
 
     @VisibleForTesting
diff --git a/mobile/android/fenix/app/src/main/res/values/strings.xml b/mobile/android/fenix/app/src/main/res/values/strings.xml
index dc95c36bc1b2..a51a48e7cc92 100644
--- a/mobile/android/fenix/app/src/main/res/values/strings.xml
+++ b/mobile/android/fenix/app/src/main/res/values/strings.xml
@@ -339,8 +339,8 @@
     <string name="reduce_cookie_banner_details_panel_title_off_for_site">Turn off Cookie Banner Reduction for %1$s?</string>
     <!-- Long text for a detail explanation indicating what will happen if cookie banner handling is off for a site, this is shown as part of the cookie banner panel in the toolbar. The first parameter is the application name -->
     <string name="reduce_cookie_banner_details_panel_description_off_for_site">%1$s will clear this site’s cookies and refresh the page. Clearing all cookies may sign you out or empty shopping carts.</string>
-    <!-- Long text for a detail explanation indicating what will happen if cookie banner handling is on for a site, this is shown as part of the cookie banner panel in the toolbar -->
-    <string name="reduce_cookie_banner_details_panel_description_on_for_site">Firefox can try to automatically reject cookie requests. If a reject option isn’t available, Firefox may accept all cookies to dismiss the banner.</string>
+    <!-- Long text for a detail explanation indicating what will happen if cookie banner handling is on for a site, this is shown as part of the cookie banner panel in the toolbar. The first and second parameter are the application name -->
+    <string name="reduce_cookie_banner_details_panel_description_on_for_site">%1$s can try to automatically reject cookie requests. If a reject option isn’t available, %2$s may accept all cookies to dismiss the banner.</string>
 
     <!-- Description of the preference to enable "HTTPS-Only" mode. -->
     <string name="preferences_https_only_summary">Automatically attempts to connect to sites using HTTPS encryption protocol for increased security.</string>
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt
index dfa9e90f3463..1170a35eeb85 100644
--- a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt
+++ b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt
@@ -131,9 +131,12 @@ class CookieBannerHandlingDetailsViewTest {
     fun `GIVEN cookie banner handling is disabled WHEN biding description THEN description view must have the expected string`() {
         view.bindDescription(isCookieBannerHandlingEnabled = false)
 
+        val appName = testContext.getString(R.string.app_name)
         val expectedText =
             testContext.getString(
                 R.string.reduce_cookie_banner_details_panel_description_on_for_site,
+                appName,
+                appName,
             )
 
         assertEquals(expectedText, view.binding.details.text)
-- 
2.11.4.GIT