From 535f80685119fa6918c13654e6300c8611181a21 Mon Sep 17 00:00:00 2001 From: Alexandru2909 Date: Mon, 4 Apr 2022 16:37:31 +0300 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/24576 - Record delete collection metric --- .../org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt | 1 + .../org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt index 900d8fa57e1f..7000ac559542 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt @@ -310,6 +310,7 @@ class DefaultSessionControlController( override fun handleDeleteCollectionTapped(collection: TabCollection) { removeCollectionWithUndo(collection) + Collections.removed.record(NoExtras()) } override fun handleOpenInPrivateTabClicked(topSite: TopSite) { diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt index 7feb2f2255d9..3516bff008bd 100644 --- a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt +++ b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt @@ -402,6 +402,10 @@ class DefaultSessionControlControllerTest { ).handleDeleteCollectionTapped(expectedCollection) assertEquals(expectedCollection, actualCollection) + assertTrue(Collections.removed.testHasValue()) + val recordedEvents = Collections.removed.testGetValue() + assertEquals(1, recordedEvents.size) + assertEquals(null, recordedEvents.single().extra) } @Test -- 2.11.4.GIT