From 43c3931ce1640d73e157afc3ffd2c7a46f78c925 Mon Sep 17 00:00:00 2001 From: Sarah Khan Date: Fri, 14 Jan 2022 19:48:20 +0530 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/23138 - Close recently visited menu on orientation change --- .../org/mozilla/fenix/home/recentvisits/view/RecentlyVisited.kt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentvisits/view/RecentlyVisited.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentvisits/view/RecentlyVisited.kt index bc31209f3b54..0d47a4df248e 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentvisits/view/RecentlyVisited.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/recentvisits/view/RecentlyVisited.kt @@ -32,12 +32,14 @@ import androidx.compose.material.DropdownMenu import androidx.compose.material.DropdownMenuItem import androidx.compose.material.Text import androidx.compose.runtime.Composable +import androidx.compose.runtime.DisposableEffect import androidx.compose.runtime.getValue import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.remember import androidx.compose.runtime.setValue import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier +import androidx.compose.ui.platform.LocalConfiguration import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.res.painterResource import androidx.compose.ui.text.style.TextOverflow @@ -306,6 +308,10 @@ private fun RecentlyVisitedMenu( recentVisit: RecentlyVisitedItem, onDismissRequest: () -> Unit, ) { + DisposableEffect(LocalConfiguration.current.orientation) { + onDispose { onDismissRequest() } + } + DropdownMenu( expanded = showMenu, onDismissRequest = { onDismissRequest() }, -- 2.11.4.GIT