From 42adf2e1ecce64f052ff4594cb975076dbc04b0f Mon Sep 17 00:00:00 2001 From: Dan Clark Date: Wed, 1 Sep 2021 14:03:56 +0000 Subject: [PATCH] Bug 1727160 [wpt PR 30130] - [selectmenu] Handle synthetic keyboard event, a=testonly Automatic update from web-platform-tests [selectmenu] Handle synthetic keyboard event An event created with createEvent can trigger selectmenu's keydown handlers, but will fail the cast to a KeyboardEvent. Check for this case and bail out to prevent a crash. Bug: 1242148 Change-Id: I5fc1aa430f89fdb76b270f0aaffdbe2eb358b86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3114727 Reviewed-by: Mason Freed Reviewed-by: Ionel Popescu Commit-Queue: Dan Clark Cr-Commit-Position: refs/heads/main@{#914506} -- wpt-commits: ea4b3c2a066761983830175df7f9312d2baf8c1e wpt-pr: 30130 --- .../selectmenu-keyboard.tentative.html | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html b/testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html index bb69c3555129..9f8debc3ea28 100644 --- a/testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html +++ b/testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html @@ -5,14 +5,17 @@ - +
button
- -- 2.11.4.GIT